From: John Keeping <john@keeping.me.uk>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v3 6/7] completion: get rid of __gitcomp_1
Date: Wed, 10 Apr 2013 12:35:31 +0100 [thread overview]
Message-ID: <20130410113531.GJ2222@serenity.lan> (raw)
In-Reply-To: <CAPig+cR4_ZB=s8JVT2LRJGcNhM9ZaESWZQ5v6Wa20=bWGoMydg@mail.gmail.com>
On Wed, Apr 10, 2013 at 06:13:06AM -0400, Eric Sunshine wrote:
> On Wed, Apr 10, 2013 at 2:57 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > we traverse the words ourselves both in __gitcompadd, and __gitcomp_1.
>
> s/ourselves/ourself/
Huh? "we traverse ... ourselves" is correct since "ourselves" is
associated with the "we". I don't think "ourself" is ever correct in
normal usage - the dictionary notes that it applies only to the "royal
we".
next prev parent reply other threads:[~2013-04-10 11:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 6:57 [PATCH v3 0/7] completion: reorg and performance improvements Felipe Contreras
2013-04-10 6:57 ` [PATCH v3 1/7] completion: trivial test improvement Felipe Contreras
2013-04-10 6:57 ` [PATCH v3 2/7] completion: get rid of empty COMPREPLY assignments Felipe Contreras
2013-04-10 9:47 ` Eric Sunshine
2013-04-10 6:57 ` [PATCH v3 3/7] completion: add new __gitcompadd helper Felipe Contreras
2013-04-12 17:55 ` Junio C Hamano
2013-04-12 18:47 ` Felipe Contreras
2013-04-12 18:51 ` Junio C Hamano
2013-04-10 6:57 ` [PATCH v3 4/7] completion: add __gitcomp_nl tests Felipe Contreras
2013-04-10 6:57 ` [PATCH v3 5/7] completion: get rid of compgen Felipe Contreras
2013-04-10 10:10 ` Eric Sunshine
2013-04-10 11:07 ` Felipe Contreras
2013-04-10 11:32 ` John Keeping
2013-04-12 18:06 ` Junio C Hamano
2013-04-10 6:57 ` [PATCH v3 6/7] completion: get rid of __gitcomp_1 Felipe Contreras
2013-04-10 10:13 ` Eric Sunshine
2013-04-10 11:35 ` John Keeping [this message]
2013-04-10 18:23 ` Eric Sunshine
2013-04-10 6:57 ` [PATCH v3 7/7] completion: small optimization Felipe Contreras
2013-04-12 18:54 ` [PATCH v3 0/7] completion: reorg and performance improvements Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410113531.GJ2222@serenity.lan \
--to=john@keeping.me.uk \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).