From: Jeff King <peff@peff.net>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] test-lint-duplicates: consider only numbered test cases
Date: Wed, 10 Apr 2013 12:03:50 -0400 [thread overview]
Message-ID: <20130410160350.GC10749@sigill.intra.peff.net> (raw)
In-Reply-To: <201304101622.58688.tboegi@web.de>
On Wed, Apr 10, 2013 at 04:22:57PM +0200, Torsten Bögershausen wrote:
> Running make inside contrib/remote-helpers may fail in "test-lint-duplicates"
>
> This was because the regexp checking for duplicate numbers strips everything
> after the first "-" in the filename, including the prefix.
>
> As a result, 2 pathnames like
> "xxxx/contrib/remote-helpers/test-XX.sh" and
> "xxxx/contrib/remote-helpers/test-YY.sh"
>
> are both converted into
> "xxxx/contrib/remote", and reported as duplicate.
>
> Improve the regexp:
> - strip the leading path and look only at the basename
> - only look at files which have tNNNN- (where N stand for a digit) in the name
>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
Yeah, I think this is fine. Though note that we already have Felipe's
patch to just set TEST_LINT explicitly, so I think it is a non-issue
now.
-Peff
prev parent reply other threads:[~2013-04-10 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 14:22 [PATCH] test-lint-duplicates: consider only numbered test cases Torsten Bögershausen
2013-04-10 16:03 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410160350.GC10749@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).