git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: Re: segfault in git-remote-http
Date: Wed, 10 Apr 2013 14:51:15 -0400	[thread overview]
Message-ID: <20130410185114.GA18084@sigill.intra.peff.net> (raw)
In-Reply-To: <20130410090850.bacd762ad52eb3643ca99927@lavabit.com>

On Wed, Apr 10, 2013 at 09:08:50AM -0700, rh wrote:

> > which should show both program names. Git invokes git-remote-* based
> > on the URL you fed it. So if you are seeing a segfault in
> > git-remote-http, presumably you fed it an http URL (which may still
> > execute SSL code if it redirects to an https URL).
> 
> Here's the command I ran (from initial post):
> git clone https://github.com/bitcoin/bitcoin.git
> 
> This returns no error on the command line and produced the segfault
> reported by the kernel. git clone returns immediately.

It does correctly report a failed exit code. The lack of message is
because git assumes that the helper will produce a useful message before
dying, but obviously it doesn't.  There's already a patch[1] to fix this,
but it hasn't been merged yet.

As for why dmesg reports git-remote-http, I'm not sure. If you "strace
-f" the command, you can see that git is running git-remote-https. Why
the kernel chooses to report "git-remote-http", I don't know; you'd have
to look into how the kernel makes that decision. But I doubt it is
related to the reason for the segfault in the first place.

-Peff

  reply	other threads:[~2013-04-10 18:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-07 16:38 segfault in git-remote-http rh
2013-04-07 16:42 ` rh
2013-04-09 15:47 ` rh
2013-04-09 17:16   ` Jeff King
2013-04-09 17:25     ` Daniel Stenberg
2013-04-12 15:20       ` rh
2013-04-09 17:41     ` rh
2013-04-09 17:47       ` Jeff King
2013-04-09 19:40         ` rh
2013-04-10  4:30           ` Jeff King
2013-04-10 16:08             ` rh
2013-04-10 18:51               ` Jeff King [this message]
2013-04-10 19:11                 ` Jeff King
2013-04-10 23:31                   ` rh
2013-04-13  1:01                   ` rh
2013-04-10 19:16                 ` rh
2013-04-10 19:54                   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130410185114.GA18084@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).