From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH 1/2] transport-helper: improve push messages
Date: Wed, 10 Apr 2013 23:41:02 -0400 [thread overview]
Message-ID: <20130411034102.GD14551@sigill.intra.peff.net> (raw)
In-Reply-To: <1365638832-9000-2-git-send-email-felipe.contreras@gmail.com>
On Wed, Apr 10, 2013 at 07:07:11PM -0500, Felipe Contreras wrote:
> If there's already a remote-helper tracking ref, we can fetch the SHA-1
> to report proper push messages (as opposed to always reporting
> [new branch]).
>
> The remote-helper currently can specify the old SHA-1 to avoid this
> problem, but there's no point in forcing all remote-helpers to be aware
> of git commit ids; they should be able to be agnostic of them.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Yeah, this looks correct to me. Thanks.
-Peff
next prev parent reply other threads:[~2013-04-11 3:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 0:07 [PATCH 0/2] transport-helper: general fixes Felipe Contreras
2013-04-11 0:07 ` [PATCH 1/2] transport-helper: improve push messages Felipe Contreras
2013-04-11 3:41 ` Jeff King [this message]
2013-04-11 0:07 ` [PATCH 2/2] transport-helper: update remote helper namespace Felipe Contreras
2013-04-11 4:33 ` Jeff King
2013-04-11 4:53 ` Felipe Contreras
2013-04-11 5:05 ` Jeff King
2013-04-11 5:18 ` Felipe Contreras
2013-04-13 6:00 ` Felipe Contreras
2013-04-14 5:13 ` Junio C Hamano
2013-04-14 15:42 ` Felipe Contreras
2013-04-14 18:45 ` Junio C Hamano
2013-04-14 19:00 ` Jeff King
2013-04-16 0:56 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411034102.GD14551@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).