git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Sverre Rabbelier <srabbelier@gmail.com>,
	Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH 1/2] transport-helper: report errors properly
Date: Sat, 13 Apr 2013 02:00:31 -0400	[thread overview]
Message-ID: <20130413060031.GA22374@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMP44s1pZW6OJ2nkegKFQq6=npPSiD4dX_z37t63B9baaFW16w@mail.gmail.com>

On Sat, Apr 13, 2013 at 12:42:29AM -0500, Felipe Contreras wrote:

> To me, the reality is obvious: my patch didn't require such a big
> commit message, the short version was fine, the only reason Jeff King
> insisted on a longer version is because the patch came from me.

Get over yourself. The reason I suggested a longer commit message for
your commit is because after spending several hours figuring out what
the current code did, and what it should be doing instead, I wanted to
document that effort so that I and other readers did not have to do it
again later. I didn't even review the other patch you mention, so I
could not possibly have come to the same point with it.

But hey, if you want to have paranoid fantasies that I'm persecuting you
(by writing the longer commit messages for you!), go ahead.

If you don't want me to review your patches, that's fine by me, too; our
discussions often end up frustrating, and it's clear we do not agree on
very much with respect to process or design. But if you don't want that,
please stop cc'ing me when you send out the patches.

-Peff

  reply	other threads:[~2013-04-13  6:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 14:40 [PATCH v4] transport-helper: report errors properly Felipe Contreras
2013-04-08 18:20 ` Sverre Rabbelier
2013-04-08 19:30   ` Jeff King
2013-04-08 19:28 ` Jeff King
2013-04-09 21:38 ` Thomas Rast
2013-04-09 21:50   ` Jeff King
2013-04-10 21:13 ` [PATCH v5 0/2] reporting transport helper errors Jeff King
2013-04-10 21:15   ` [PATCH 1/2] transport-helper: report errors properly Jeff King
2013-04-10 21:22     ` Sverre Rabbelier
2013-04-10 21:46     ` Eric Sunshine
2013-04-11 13:22     ` Felipe Contreras
2013-04-11 16:18       ` Jeff King
2013-04-11 16:49         ` Felipe Contreras
2013-04-11 16:59           ` Jeff King
2013-04-11 17:57             ` Felipe Contreras
2013-04-11 18:49               ` Junio C Hamano
2013-04-11 21:35                 ` Felipe Contreras
2013-04-11 18:44       ` Junio C Hamano
2013-04-11 21:21         ` Felipe Contreras
2013-04-11 23:05           ` Junio C Hamano
2013-04-13  5:42             ` Felipe Contreras
2013-04-13  6:00               ` Jeff King [this message]
2013-04-13  6:43                 ` Felipe Contreras
2013-04-14  5:23                   ` Junio C Hamano
2013-04-14 15:54                     ` Felipe Contreras
2013-04-10 21:16   ` [PATCH 2/2] transport-helper: mention helper name when it dies Jeff King
2013-04-10 21:23     ` Sverre Rabbelier
2013-04-10 21:28       ` Jeff King
2013-04-10 21:35         ` Sverre Rabbelier
2013-04-10 23:13 ` [PATCH v4] transport-helper: report errors properly rh
2013-04-11  3:39   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130413060031.GA22374@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=srabbelier@gmail.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).