From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Brandon Casey <drafnel@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] usage: refactor die-recursion checks
Date: Mon, 15 Apr 2013 18:41:45 -0700 [thread overview]
Message-ID: <20130416014145.GC3262@elie.Belkin> (raw)
In-Reply-To: <20130416004228.GA14995@sigill.intra.peff.net>
Jeff King wrote:
> I was also tempted to suggest just dropping the recursion check
> altogether. While it is neat to detect such things, it's a "should never
> happen" bug situation, and an infinite loop of printing out the same
> message is pretty easy to notice.
On servers it might be useful to avoid accidentally filling up logs
quickly.
IIUC the context is in the following two threads:
http://thread.gmane.org/gmane.comp.version-control.git/182982
http://thread.gmane.org/gmane.comp.version-control.git/181421/focus=181443
Thanks,
Jonathan
next prev parent reply other threads:[~2013-04-16 1:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 23:06 [PATCH 0/3] avoid bogus "recursion detected in die handler" message Jeff King
2013-04-15 23:08 ` [PATCH 1/3] usage: refactor die-recursion checks Jeff King
2013-04-15 23:45 ` Eric Sunshine
2013-04-15 23:47 ` Jeff King
2013-04-16 0:11 ` Brandon Casey
2013-04-16 0:42 ` Jeff King
2013-04-16 1:41 ` Jonathan Nieder [this message]
2013-04-16 2:34 ` Brandon Casey
2013-04-16 2:50 ` Jeff King
2013-04-16 7:18 ` Johannes Sixt
2013-04-16 13:01 ` Jeff King
2013-04-16 14:13 ` Johannes Sixt
2013-04-16 19:44 ` [PATCH v2 0/2] avoid bogus "recursion detected in die handler" message Jeff King
2013-04-16 19:46 ` [PATCH v2 1/2] usage: allow pluggable die-recursion checks Jeff King
2013-04-16 19:50 ` [PATCH v2 2/2] run-command: use thread-aware die_is_recursing routine Jeff King
2013-04-16 22:09 ` Junio C Hamano
2013-04-17 0:49 ` [PATCH v2 0/2] avoid bogus "recursion detected in die handler" message Jonathan Nieder
2013-04-17 1:37 ` Jeff King
2013-04-23 21:27 ` Erik Faye-Lund
2013-04-15 23:08 ` [PATCH 2/3] run-command: factor out running_main_thread function Jeff King
2013-04-16 1:45 ` Jonathan Nieder
2013-04-16 2:53 ` Jeff King
2013-04-15 23:09 ` [PATCH 3/3] usage: do not check die recursion outside main thread Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416014145.GC3262@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).