From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: William Giokas <1007380@gmail.com>,
git@vger.kernel.org, fsckdaemon@gmail.com,
Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [BUG] Filenames with single colon being treated as remote repository
Date: Sun, 21 Apr 2013 09:56:06 -0700 [thread overview]
Message-ID: <20130421165606.GA29687@elie.Belkin> (raw)
In-Reply-To: <20130421124511.GA1933@sigill.intra.peff.net>
Jeff King wrote:
> I don't think that is enough. Something like /path/to/foo:bar would
> trigger !is_url already, but then git_connect fails.
Doh. Here's another try, still untested.
diff --git i/connect.c w/connect.c
index 49e56ba3..fe13942f 100644
--- i/connect.c
+++ w/connect.c
@@ -504,6 +504,7 @@ struct child_process *git_connect(int fd[2], const char *url_orig,
int c;
struct child_process *conn = &no_fork;
enum protocol protocol = PROTO_LOCAL;
+ struct stat st;
int free_path = 0;
char *port = NULL;
const char **arg;
@@ -548,7 +549,8 @@ struct child_process *git_connect(int fd[2], const char *url_orig,
end = host;
path = strchr(end, c);
- if (path && !has_dos_drive_prefix(end)) {
+ if (path && !has_dos_drive_prefix(end) &&
+ (c != ':' || stat(path, &st))) {
if (c == ':') {
protocol = PROTO_SSH;
*path++ = '\0';
next prev parent reply other threads:[~2013-04-21 16:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 4:53 [BUG] Filenames with single colon being treated as remote repository William Giokas
2013-04-21 6:05 ` Jonathan Nieder
2013-04-21 12:45 ` Jeff King
2013-04-21 16:56 ` Jonathan Nieder [this message]
2013-04-21 18:01 ` Junio C Hamano
2013-04-22 15:35 ` Jeff King
2013-04-22 16:00 ` Junio C Hamano
2013-04-27 3:36 ` [PATCH] clone: allow cloning local paths with colons in them Nguyễn Thái Ngọc Duy
2013-04-27 20:08 ` William Giokas
2013-04-27 21:16 ` Junio C Hamano
2013-04-28 0:19 ` Duy Nguyen
2013-04-28 1:48 ` Eric Sunshine
2013-04-28 2:15 ` Duy Nguyen
2013-05-04 2:19 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-05-07 15:34 ` Junio C Hamano
2013-05-07 16:47 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130421165606.GA29687@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=1007380@gmail.com \
--cc=barkalow@iabervon.org \
--cc=fsckdaemon@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).