From: "Torsten Bögershausen" <tboegi@web.de>
To: git@vger.kernel.org
Subject: [PATCH] check-non-portable-shell: Check for non portable grep usage
Date: Thu, 25 Apr 2013 20:48:18 +0200 [thread overview]
Message-ID: <201304252048.19235.tboegi@web.de> (raw)
The make test-lint could check for some common non portable
grep usage:
The + as a qualifier is not a "basic regular expression".
Some grep understand \+, but in general egrep should be used.
The \t can not be used to find an ASCII TAB, neither
can \s be used to find a whitespace
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
t/check-non-portable-shell.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index ff87611..58f8e2c 100755
--- a/t/check-non-portable-shell.pl
+++ b/t/check-non-portable-shell.pl
@@ -16,6 +16,8 @@ sub err {
while (<>) {
chomp;
+ / e?grep\s+\"[^"]*\\([st])/ and err "grep \\$1 is not portable)";
+ / [^e]grep.*\\\+/ and err 'grep with \+ is not portable (please use egrep)';
/^\s*sed\s+-i/ and err 'sed -i is not portable';
/^\s*echo\s+-(\S)\s+/ and err "echo -$1 is not portable (please use printf)";
/^\s*declare\s+/ and err 'arrays/declare not portable';
--
1.8.2.1.614.g66d7af5
next reply other threads:[~2013-04-25 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 18:48 Torsten Bögershausen [this message]
2013-04-25 20:44 ` [PATCH] check-non-portable-shell: Check for non portable grep usage Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304252048.19235.tboegi@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).