From: "Torsten Bögershausen" <tboegi@web.de>
To: git@vger.kernel.org
Subject: [PATCH] test-lint-shell-syntax: Allow bash syntax in bash tests
Date: Thu, 25 Apr 2013 20:48:33 +0200 [thread overview]
Message-ID: <201304252048.33803.tboegi@web.de> (raw)
t/check-non-portable-sh.pl checks for bash only syntax like test $a == $b
This is wrong when bash is used.
Switch to bash mode and skip this test
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
t/check-non-portable-shell.pl | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index 58f8e2c..1ca8c8b 100755
--- a/t/check-non-portable-shell.pl
+++ b/t/check-non-portable-shell.pl
@@ -7,23 +7,26 @@ use strict;
use warnings;
my $exit_code=0;
+my $bashmode=0;
sub err {
my $msg = shift;
- print "$ARGV:$.: error: $msg: $_\n";
+ print "$ARGV:$.: error: (bashmode=$bashmode) $msg: $_\n";
$exit_code = 1;
}
while (<>) {
chomp;
+ /^\. \.\/lib\-bash.sh/ and $bashmode=1;
/ e?grep\s+\"[^"]*\\([st])/ and err "grep \\$1 is not portable)";
/ [^e]grep.*\\\+/ and err 'grep with \+ is not portable (please use egrep)';
/^\s*sed\s+-i/ and err 'sed -i is not portable';
/^\s*echo\s+-(\S)\s+/ and err "echo -$1 is not portable (please use printf)";
/^\s*declare\s+/ and err 'arrays/declare not portable';
/^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
- /test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
+ $bashmode==0 and /test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
# this resets our $. for each file
close ARGV if eof;
+ $bashmode=0 if eof;
}
exit $exit_code;
--
1.8.2.1.614.g66d7af5
reply other threads:[~2013-04-25 18:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304252048.33803.tboegi@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).