git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Keeping <john@keeping.me.uk>
To: Steffen Jaeckel <steffen.jaeckel@stzedn.de>
Cc: git@vger.kernel.org
Subject: Re: Unexpected behavior of git-subtree
Date: Mon, 29 Apr 2013 19:20:52 +0100	[thread overview]
Message-ID: <20130429182052.GN472@serenity.lan> (raw)
In-Reply-To: <1003348467.20130429193427@stzedn.de>

On Mon, Apr 29, 2013 at 07:34:27PM +0200, Steffen Jaeckel wrote:
> lately I used git-subtree to integrate a submodule directly into a
> repository. Now I wanted to push the changes back to the original
> repository of the submodule and I was a bit surprised by what
> happened...
> 
> 
> ---- snip ----
> sjaeckel@T7400-003 /h/projects/my_project (develop)
> $ GIT_TRACE=2 git subtree push --prefix=lib/com_lib/ git@git.local:com_lib develop -b develop
> trace: exec: 'git-subtree' 'push' '--prefix=lib/com_lib/' 'git@git.local:com_lib' 'develop' '-b' 'develop'
> trace: run_command: 'git-subtree' 'push' '--prefix=lib/com_lib/' 'git@git.local:com_lib' 'develop' '-b' 'develop'
> trace: built-in: git 'rev-parse' '--parseopt' '--' 'push' '--prefix=lib/com_lib/' 'git@git.local:com_lib' 'develop' '-b' 'develop'
> trace: built-in: git 'rev-parse' '--git-dir'
> trace: built-in: git 'rev-parse' '--show-cdup'
> git push using:  git@git.local:com_lib develop
> trace: exec: 'git-subtree' 'split' '--prefix=lib/com_lib/'
> trace: run_command: 'git-subtree' 'split' '--prefix=lib/com_lib/'
> trace: built-in: git 'rev-parse' '--parseopt' '--' 'split' '--prefix=lib/com_lib/'
> trace: built-in: git 'rev-parse' '--git-dir'
> trace: built-in: git 'rev-parse' '--show-cdup'
> trace: built-in: git 'rev-parse' '--default' 'HEAD' '--revs-only'
> trace: built-in: git 'rev-parse' '--no-revs' '--no-flags'
> trace: built-in: git 'log' '--grep=^git-subtree-dir: lib/com_lib/*$' '--pretty=format:START %H%n%s%n%n%b%nEND%n' '8068a810709f6284b04a18ff38dbb72c36b8d9c6'
> trace: built-in: git 'rev-list' '--topo-order' '--reverse' '--parents' '8068a810709f6284b04a18ff38dbb72c36b8d9c6'
> trace: built-in: git 'rev-list' '--topo-order' '--reverse' '--parents' '8068a810709f6284b04a18ff38dbb72c36b8d9c6'
> 1/    102 (0)trace: built-in: git 'ls-tree' 'f6e1457d345029cf4d376ff3cf780cbb8c3080b4' '--' 'lib/com_lib'
> ..... loads of more git 'ls-tree'...
> 71/    102 (70)72/    102 (70)trace: built-in: git 'ls-tree' '48dc0efb9a148b1146b013554f8bf4635adf7a0d' '--' 'lib/com_lib'
> trace: built-in: git 'log' '-1' '--pretty=format:%T' '6299b48765e11302aca48cc9fca88735aeab7c54' '--'
> fatal: bad object 6299b48765e11302aca48cc9fca88735aeab7c54

Without knowing much about git-subtree, this looks like the culprit.  A
quick look at cmd_push in git-subtree.sh indicates that it doesn't check
for an error return from 'git subtree split --prefix=$prefix', so if
that goes wrong you end up doing:

    git push $repository :refs/heads/$refspec

which deletes the branch.

Can you try running this:

    git subtree split --prefix=lib/com_lib/

and see if that gives the same "fatal: bad object" message as above?

  reply	other threads:[~2013-04-29 18:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-29 17:34 Unexpected behavior of git-subtree Steffen Jaeckel
2013-04-29 18:20 ` John Keeping [this message]
2013-04-30 11:13   ` Steffen Jaeckel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130429182052.GN472@serenity.lan \
    --to=john@keeping.me.uk \
    --cc=git@vger.kernel.org \
    --cc=steffen.jaeckel@stzedn.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).