From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Heiko Voigt <hvoigt@hvoigt.net>,
git@vger.kernel.org
Subject: Re: [PATCH v2] remove the impression of unexpectedness when access is denied
Date: Tue, 7 May 2013 14:39:37 -0400 [thread overview]
Message-ID: <20130507183937.GA5776@sigill.intra.peff.net> (raw)
In-Reply-To: <7vr4hktddq.fsf@alter.siamese.dyndns.org>
On Mon, May 06, 2013 at 07:02:41AM -0700, Junio C Hamano wrote:
> > Would it make sense for the server to send an "ERR" packet to give
> > a more helpful diagnosis?
>
> I think git-daemon does so (or at least attempts to do so);
> path_ok() uses enter_repo() to check if the given path is a
> repository, returns NULL to run_service(), whichh in turn calls
> daemon_error() that does the ERR thing.
Yeah, that went into v1.7.8. Do we have any simple way to find out which
version kernel.org is running? They should probably also turn on the
--informative-errors option, as they do not (AFAIK) have any private
repos whose information could be leaked by better error messages.
If they are running v1.7.8 and it is not producing an ERR message, then
I think there is a bug.
> > * The error message is the same whether the server returned no
> > response or an incomplete pkt-line. Maybe in the latter case it
> > should print the "hung up unexpectedly" thing.
>
> OK.
I made a stab at this some time ago:
http://article.gmane.org/gmane.comp.version-control.git/112189
There were some follow-up comments, and I remember trying to make
something work with processing remote stderr, but running into
complications. Alas, I don't remember any more details than that. But
maybe it helps.
-Peff
prev parent reply other threads:[~2013-05-07 18:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 18:23 [PATCH] lessen the impression of unexpectedness on remote hangup Heiko Voigt
2012-06-10 18:44 ` Jonathan Nieder
2012-06-11 16:41 ` Junio C Hamano
2012-06-11 19:02 ` Jeff King
2012-06-13 21:28 ` Heiko Voigt
2012-06-14 7:13 ` [PATCH] remove the impression of unexpectedness when access is denied Heiko Voigt
2012-06-14 7:39 ` Heiko Voigt
2012-06-14 17:11 ` Junio C Hamano
2012-06-14 20:37 ` Heiko Voigt
2012-06-19 18:24 ` [PATCH v2] " Heiko Voigt
2013-05-04 3:10 ` Jonathan Nieder
2013-05-06 14:02 ` Junio C Hamano
2013-05-07 18:39 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507183937.GA5776@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).