From: John Keeping <john@keeping.me.uk>
To: David Aguilar <davvid@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Charles Bailey <charles@hashpling.org>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [RFC PATCH 3/3] Makefile: avoid deprecation warnings on OS X 10.8
Date: Thu, 9 May 2013 16:14:36 +0100 [thread overview]
Message-ID: <20130509151436.GJ25912@serenity.lan> (raw)
In-Reply-To: <1368090810-40596-3-git-send-email-davvid@gmail.com>
On Thu, May 09, 2013 at 02:13:30AM -0700, David Aguilar wrote:
> Mac OS X Mountain Lion prints warnings when building git:
>
> warning: 'SHA1_Init' is deprecated
> (declared at /usr/include/openssl/sha.h:121)
>
> Silence the warnings by disabling OpenSSH in favor of BLK_SHA1.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
> I know I can create config.mak, but do we prefer to have the default
> settings be warning-free? I do not see any other platforms that tweak
> NO_OPENSSL themselves, hence "RFC". Is there a better way to do this?
> Are there any Darwin/PPC users that would be harmed by this patch?
Disabling OpenSSL also has the effect of disabling SSL support in
git-imap-send. Does enabling BLK_SHA1 instead also remove the warnings?
Alternatively, it seems that the recommended update is to use Apple's
CommonCrypto library, as in this patch:
https://gist.github.com/anonymous/4466305
next prev parent reply other threads:[~2013-05-09 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 9:13 [PATCH 1/3] mergetools/kdiff3: do not use --auto when diffing David Aguilar
2013-05-09 9:13 ` [RFC PATCH 2/3] mergetools/kdiff3: allow opting-out of auto-merges David Aguilar
2013-05-09 9:13 ` [RFC PATCH 3/3] Makefile: avoid deprecation warnings on OS X 10.8 David Aguilar
2013-05-09 15:14 ` John Keeping [this message]
2013-05-09 23:21 ` David Aguilar
2013-05-09 16:10 ` [RFC PATCH 2/3] mergetools/kdiff3: allow opting-out of auto-merges Junio C Hamano
2013-05-09 17:23 ` John Keeping
2013-05-09 19:15 ` Junio C Hamano
2013-05-09 22:17 ` David Aguilar
2013-05-10 5:41 ` Charles Bailey
2013-05-10 18:40 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509151436.GJ25912@serenity.lan \
--to=john@keeping.me.uk \
--cc=charles@hashpling.org \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).