From: Jeff King <peff@peff.net>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jens Lehmann <jens.lehmann@web.de>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: [PATCH v3 0/5] allow more sources for config values
Date: Fri, 10 May 2013 00:41:25 +0200 [thread overview]
Message-ID: <20130509224124.GD30774@sigill.intra.peff.net> (raw)
In-Reply-To: <20130509161636.GB3526@book-mint>
On Thu, May 09, 2013 at 06:16:36PM +0200, Heiko Voigt wrote:
> This is an update with the comments of the second iteration[1] incorporated.
>
> [1] http://thread.gmane.org/gmane.comp.version-control.git/217811
>
> Heiko Voigt (5):
> config: factor out config file stack management
> config: drop cf validity check in get_next_char()
> config: make parsing stack struct independent from actual data source
> teach config --blob option to parse config from database
> do not die when error in config parsing of buf occurs
Thanks, I think it looks good except for a few minor things I mentioned.
-Peff
prev parent reply other threads:[~2013-05-09 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 16:16 [PATCH v3 0/5] allow more sources for config values Heiko Voigt
2013-05-09 21:00 ` Junio C Hamano
2013-05-09 22:41 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509224124.GD30774@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jens.lehmann@web.de \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).