From: Miklos Vajna <vmiklos@suse.cz>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v3] cherry-pick: make sure all input objects are commits
Date: Fri, 10 May 2013 09:07:13 +0200 [thread overview]
Message-ID: <20130510070712.GA24415@suse.cz> (raw)
In-Reply-To: <7vsj1v99ve.fsf@alter.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
On Thu, May 09, 2013 at 01:27:49PM -0700, Junio C Hamano <gitster@pobox.com> wrote:
> I'd apply this before -rc2. I _think_ it is also OK to just let
> lookup_commit_reference_gently() barf with its standard message
>
> error: Object %s is a %s, not a commit
>
> without an extra sha1_object_info() call in the error codepath, but
> I did not bother, as this is meant to be an emergency fix.
Yes, that makes a lot of sense. I myself never cherry-pick tags, but I
understand that is part of some workflow.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2013-05-10 7:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 9:27 [PATCH] cherry-pick: better error message when the parameter is a non-commit Miklos Vajna
2013-04-08 12:27 ` Miklos Vajna
2013-04-08 16:45 ` Junio C Hamano
2013-04-08 16:56 ` Junio C Hamano
2013-04-11 9:26 ` [PATCH v2] cherry-pick: make sure all input objects are commits Miklos Vajna
2013-04-11 10:22 ` Ramkumar Ramachandra
2013-04-11 11:03 ` Miklos Vajna
2013-04-11 11:42 ` Ramkumar Ramachandra
2013-04-11 13:06 ` [PATCH v3] " Miklos Vajna
2013-04-11 13:27 ` Ramkumar Ramachandra
2013-04-15 8:44 ` Thomas Rast
2013-04-15 18:29 ` Junio C Hamano
2013-04-15 19:12 ` Junio C Hamano
2013-04-16 14:22 ` Michael Haggerty
2013-05-09 19:47 ` Junio C Hamano
2013-05-09 20:27 ` Junio C Hamano
2013-05-10 7:07 ` Miklos Vajna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510070712.GA24415@suse.cz \
--to=vmiklos@suse.cz \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).