From: Heiko Voigt <hvoigt@hvoigt.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jens Lehmann <jens.lehmann@web.de>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: Re: [PATCH v3 4/5] teach config --blob option to parse config from database
Date: Fri, 10 May 2013 17:47:35 +0200 [thread overview]
Message-ID: <20130510154735.GA3850@book-mint> (raw)
In-Reply-To: <20130509223038.GB30774@sigill.intra.peff.net>
On Fri, May 10, 2013 at 12:30:39AM +0200, Jeff King wrote:
> On Thu, May 09, 2013 at 06:20:18PM +0200, Heiko Voigt wrote:
>
> > +static int config_buf_fgetc(struct config_source *conf)
> > +{
> > + if (conf->buf.pos < conf->buf.len && conf->buf.buf[conf->buf.pos])
> > + return conf->buf.buf[conf->buf.pos++];
> > +
> > + return EOF;
> > +}
>
> It probably would not matter for config reading, but is there any reason
> not to make your fgetc replacement 8-bit clean (i.e., to check only len,
> and not worry about NUL characters)?
I got a NULL character here and by mistake thought that somehow the len
would include the ending character. But that was a bug introduced by me
when I refactored to buffer and length instead of strbuf. I missed to
transport the len properly. So I will removed this check again.
Cheers Heiko
next prev parent reply other threads:[~2013-05-10 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130509154020.GA26423@book-mint>
2013-05-09 16:17 ` [PATCH v3 1/5] config: factor out config file stack management Heiko Voigt
2013-05-09 16:18 ` [PATCH v3 2/5] config: drop cf validity check in get_next_char() Heiko Voigt
2013-05-09 16:19 ` [PATCH v3 3/5] config: make parsing stack struct independent from actual data source Heiko Voigt
2013-05-09 22:21 ` Jeff King
2013-05-09 16:20 ` [PATCH v3 4/5] teach config --blob option to parse config from database Heiko Voigt
2013-05-09 18:23 ` Eric Sunshine
2013-05-09 22:30 ` Jeff King
2013-05-10 15:47 ` Heiko Voigt [this message]
2013-05-09 16:21 ` [PATCH v3 5/5] do not die when error in config parsing of buf occurs Heiko Voigt
2013-05-09 18:23 ` Eric Sunshine
2013-05-09 22:39 ` Jeff King
2013-05-11 8:55 ` Heiko Voigt
2013-05-11 9:59 ` Jeff King
2013-05-11 10:30 ` Heiko Voigt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510154735.GA3850@book-mint \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jens.lehmann@web.de \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).