From: Jonathan Nieder <jrnieder@gmail.com>
To: David Aguilar <davvid@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
Mike McCormack <mike@codeweavers.com>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH] imap-send: eliminate HMAC warnings on OS X 10.8
Date: Fri, 10 May 2013 23:27:36 -0700 [thread overview]
Message-ID: <20130511062736.GE3394@elie> (raw)
In-Reply-To: <1368247406-10334-1-git-send-email-davvid@gmail.com>
David Aguilar wrote:
> Mac OS X Mountain Lion warns that HMAC_Init() and friends are
> deprecated. Use CommonCrypto's HMAC to eliminate the warnings.
Makes sense, and if the #define trick stops working some day
due to some conflicting macro in an openssl header some day, it
would just break the build, so this should be safe. For what it's
worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
[...]
> This builds upon the patch I sent earlier, so technically it's 2/2
I'm less sure about whether patch 1/2 is a good idea. Luckily the
conflicts when trying to untangle the two are only textual.
Thanks,
Jonathan
prev parent reply other threads:[~2013-05-11 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 4:43 [PATCH] imap-send: eliminate HMAC warnings on OS X 10.8 David Aguilar
2013-05-11 6:27 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130511062736.GE3394@elie \
--to=jrnieder@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=mike@codeweavers.com \
--cc=mitake@dcl.info.waseda.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).