From: Jeff King <peff@peff.net>
To: David Aguilar <davvid@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
John Keeping <john@keeping.me.uk>
Subject: Re: [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8
Date: Sat, 11 May 2013 10:22:03 +0200 [thread overview]
Message-ID: <20130511082203.GA953@sigill.intra.peff.net> (raw)
In-Reply-To: <CAJDDKr6QkeSk32kNhU_QuvrZSGUEokcEbN7Aq3PcOhvaA_hFgg@mail.gmail.com>
On Sat, May 11, 2013 at 12:11:05AM -0700, David Aguilar wrote:
> > Does this perform better or worse than just setting
> > BLK_SHA1=YesPlease? I'd naively think it could go either way: on one
> > hand adding another library dependency can slow down startup, and on
> > the other hand the implementation may or may not be optimized better
> > than the generic block-sha1/ implementation.
>
> Pretty much identical.
>
> Here are the timings (I should probably read t/perf/README and get
> better numbers):
>
> Best of ten
> $ time git rev-list --all --objects >/dev/null
> [...]
I'm not sure that's a great test of sha1 performance. It will hash the
commit and tree objects it loads during the traversal, but that time is
almost certainly dwarfed by zlib inflation and by lookup_object.
Adding "--verify-objects" would sha1 the blobs, too, which might be more
reasonable (or running "git fsck"). Something like "git add" on a large
blob would also be a good test.
-Peff
next prev parent reply other threads:[~2013-05-11 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 2:44 [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8 David Aguilar
2013-05-11 6:23 ` Jonathan Nieder
2013-05-11 7:11 ` David Aguilar
2013-05-11 8:22 ` Jeff King [this message]
2013-05-11 8:38 ` David Aguilar
2013-05-11 8:45 ` Jeff King
2013-05-11 9:17 ` David Aguilar
2013-05-11 9:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130511082203.GA953@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).