From: "Torsten Bögershausen" <tboegi@web.de>
To: felipe.contreras@gmail.com
Cc: git@vger.kernel.org
Subject: [PATCH] test-bzr: Do not use unportable sed "\+"
Date: Sat, 11 May 2013 15:25:52 +0200 [thread overview]
Message-ID: <201305111525.53130.tboegi@web.de> (raw)
Using sed -e '/[0-9]\+//' to find "one ore more" digits
is not portable.
Use the Basic Regular Expression '/[0-9][0-9]*//' instead
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
contrib/remote-helpers/test-bzr.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh
index d9c32f4..5dfa070 100755
--- a/contrib/remote-helpers/test-bzr.sh
+++ b/contrib/remote-helpers/test-bzr.sh
@@ -328,7 +328,7 @@ test_expect_success 'strip' '
echo four >> content &&
bzr commit -m four &&
- bzr log --line | sed -e "s/^[0-9]\+: //" > ../expected
+ bzr log --line | sed -e "s/^[0-9][0-9]*: //" > ../expected
) &&
(cd gitrepo &&
--
1.8.2.1.614.g66d7af5
next reply other threads:[~2013-05-11 13:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 13:25 Torsten Bögershausen [this message]
2013-05-11 18:52 ` [PATCH] test-bzr: Do not use unportable sed "\+" Junio C Hamano
2013-05-11 19:45 ` Junio C Hamano
2013-05-11 20:00 ` Torsten Bögershausen
2013-05-11 20:09 ` Junio C Hamano
2013-05-11 20:35 ` Torsten Bögershausen
2013-05-12 3:14 ` Junio C Hamano
2013-05-12 22:50 ` [PATCH] t5551: do not use unportable sed '\+' Junio C Hamano
2013-05-13 15:17 ` Torsten Bögershausen
2013-05-13 16:30 ` Junio C Hamano
2013-05-13 18:24 ` Torsten Bögershausen
2013-05-13 18:36 ` Junio C Hamano
2013-05-11 20:11 ` [PATCH] test-bzr: Do not use unportable sed "\+" Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305111525.53130.tboegi@web.de \
--to=tboegi@web.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).