From: Paul Mackerras <paulus@samba.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH] gitk: simplify file filtering
Date: Mon, 13 May 2013 10:36:02 +1000 [thread overview]
Message-ID: <20130513003602.GA8046@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <7vmwrzu7vt.fsf@alter.siamese.dyndns.org>
On Sun, May 12, 2013 at 03:54:14PM -0700, Junio C Hamano wrote:
> Paul Mackerras <paulus@samba.org> writes:
>
> > On Sat, Apr 27, 2013 at 05:01:39PM -0500, Felipe Contreras wrote:
> >> git diff is perfectly able to do this with '-- files', no need for
> >> manual filtering.
> >>
> >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >
> > Thanks, applied, with the commit message expanded to say that this
> > makes gettreediffs do the same as getblobdiffs.
> >
> > Paul.
>
> Thanks; is this the last one for this cycle and is your usual branch
> ready to be pulled?
I'm still deciding whether to put in Martin Langhoff's patch with a
modified label ("changing lines matching" rather than "with changes
matching regex"). I'm leaning towards it but was waiting a little to
see if anyone had comments on the wording. I'll decide by the end of
today and send you a pull request either way.
Thanks,
Paul.
next prev parent reply other threads:[~2013-05-13 0:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 22:01 [PATCH] gitk: simplify file filtering Felipe Contreras
2013-05-11 9:42 ` Paul Mackerras
2013-05-12 22:54 ` Junio C Hamano
2013-05-13 0:36 ` Paul Mackerras [this message]
2013-05-13 8:58 ` Stefan Haller
2013-05-13 11:37 ` Paul Mackerras
2013-05-13 11:34 ` Paul Mackerras
2013-05-13 14:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513003602.GA8046@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=Jens.Lehmann@web.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).