Git development
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string
Date: Mon, 13 May 2013 11:17:19 +0200	[thread overview]
Message-ID: <20130513091718.GA21636@goldbirke> (raw)
In-Reply-To: <CALkWK0m0dT-sX=nu5jaDj=y1oOSo0cRKQ=2K_S-yepnsm8ny7A@mail.gmail.com>

On Mon, May 13, 2013 at 01:10:26PM +0530, Ramkumar Ramachandra wrote:
> Junio C Hamano wrote:
> > grouping related things together, and
> > separating groups of different kind apart, to make it more readable.
> 
> You could argue that the colors are not very well thought-out
> (branch-name has the same color as +), but I really don't see the
> problem otherwise.  How is this more readable:
> 
>     artagnon|master *=:~/src/git$
> 
> than:
> 
>     artagnon|master*=:~/src/git$
> 
> (where master is green, * is red, and = is white)?

IMHO that's just ugly ;)

Don't forget that others might use a different prompt format and using
colors in the prompt is optional.  With the default prompt format and
without colors I find that that space definitely helps readability.


Gábor

  reply	other threads:[~2013-05-13  9:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11 16:25 [PATCH 0/2] Colored prompt for zsh Ramkumar Ramachandra
2013-05-11 16:25 ` [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string Ramkumar Ramachandra
2013-05-13  4:57   ` Junio C Hamano
2013-05-13  7:40     ` Ramkumar Ramachandra
2013-05-13  9:17       ` SZEDER Gábor [this message]
2013-05-13 10:13         ` Ramkumar Ramachandra
2013-05-13 11:05           ` SZEDER Gábor
2013-05-13 11:11             ` SZEDER Gábor
2013-05-13 13:58               ` Junio C Hamano
2013-05-13 14:21                 ` Ramkumar Ramachandra
2013-05-11 16:25 ` [PATCH 2/2] git-prompt.zsh: introduce thin ZSH wrapper Ramkumar Ramachandra
2013-05-11 21:26   ` Felipe Contreras
2013-05-11 22:18     ` [PATCH v2] git-prompt.sh: colorize ZSH prompt Ramkumar Ramachandra
2013-05-11 22:29       ` Felipe Contreras
2013-05-11 22:40         ` Ramkumar Ramachandra
2013-05-11 23:06           ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130513091718.GA21636@goldbirke \
    --to=szeder@ira.uka.de \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox