From: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
To: Theodore Ts'o <tytso@mit.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] guilt: fix date parsing
Date: Tue, 21 May 2013 23:39:21 -0400 [thread overview]
Message-ID: <20130522033921.GB101217@meili.valhalla.31bits.net> (raw)
In-Reply-To: <1369192411-8842-1-git-send-email-tytso@mit.edu>
I applied this one and the "guilt: skip empty line after..." patch.
Jeff.
On Tue, May 21, 2013 at 11:13:31PM -0400, Theodore Ts'o wrote:
> If the date field has a space in it, such as:
>
> Date: Tue, 14 May 2013 18:37:15 +0200
>
> previously guilt would go belly up:
>
> + export GIT_AUTHOR_DATE=Tue, 14 May 2013 18:37:15 +0200
> /usr/local/bin/guilt: 571: export: 14: bad variable name
>
> Fix this.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> ---
> guilt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guilt b/guilt
> index 9953bdf..6e8d542 100755
> --- a/guilt
> +++ b/guilt
> @@ -568,7 +568,7 @@ commit()
> author_date_str=`sed -n -e '/^Date:/ { s/^Date: //; p; q; }; /^(diff |---$|--- )/ q' "$p"`
> fi
> if [ ! -z "$author_date_str" ]; then
> - export GIT_AUTHOR_DATE=`echo $author_date_str`
> + export GIT_AUTHOR_DATE="$author_date_str"
> fi
> fi
>
> --
> 1.7.12.rc0.22.gcdd159b
>
--
The obvious mathematical breakthrough would be development of an easy way to
factor large prime numbers.
- Bill Gates, The Road Ahead, pg. 265
next prev parent reply other threads:[~2013-05-22 3:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 3:13 [PATCH] guilt: fix date parsing Theodore Ts'o
2013-05-22 3:39 ` Josef 'Jeff' Sipek [this message]
2013-05-22 12:10 ` Theodore Ts'o
2013-05-22 13:31 ` Josef 'Jeff' Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522033921.GB101217@meili.valhalla.31bits.net \
--to=jeffpc@josefsipek.net \
--cc=git@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).