From: John Keeping <john@keeping.me.uk>
To: Petr Baudis <pasky@ucw.cz>
Cc: Thomas Rast <trast@inf.ethz.ch>,
Junio C Hamano <gitster@pobox.com>,
Jim Greenleaf <james.a.greenleaf@gmail.com>,
git@vger.kernel.org
Subject: Re: git stash deletes/drops changes of
Date: Fri, 24 May 2013 13:42:42 +0100 [thread overview]
Message-ID: <20130524124242.GD27005@serenity.lan> (raw)
In-Reply-To: <20130524110322.GP12252@machine.or.cz>
On Fri, May 24, 2013 at 01:03:22PM +0200, Petr Baudis wrote:
> On Fri, May 24, 2013 at 11:40:18AM +0100, John Keeping wrote:
> > So that it continues to Just Work for people using buildroot but you can
> > create Makefile.config to override those defaults.
>
> Indeed, that doesn't cover some corner cases of (c), but that's not a
> big deal in practice I guess.
>
> My point still stands - this is extra hassle, done just for the sake
> of the tool; I think the tool should not get in the way. Moreover, it's
> not the default solution for your typical original author and therefore
> you will still often find yourself in a situation where you have to deal
> with a setup that's broken already.
I think we're in violent agreement here.
I can see that there are cases where an --ignore-changes option that
behaves like --assume-unchanged but without ever overwriting the local
file is a useful feature. I was simply trying to point at what I
consider best practices for makefiles, which was relevant for the
example you gave. Sorry if that was unclear.
next prev parent reply other threads:[~2013-05-24 12:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 16:24 git stash deletes/drops changes of "assume-unchanged" files Adeodato Simó
2013-05-23 16:57 ` git stash deletes/drops changes of Jim Greenleaf
2013-05-23 22:10 ` Thomas Rast
2013-05-23 22:49 ` Junio C Hamano
2013-05-23 22:56 ` Thomas Rast
2013-05-23 23:20 ` Junio C Hamano
2013-05-24 15:25 ` Phil Hord
2013-05-24 15:34 ` Jim Greenleaf
2013-05-24 15:38 ` John Keeping
2013-05-24 15:42 ` Jim Greenleaf
2013-05-24 16:01 ` John Keeping
2013-05-23 23:57 ` Petr Baudis
2013-05-24 8:22 ` John Keeping
2013-05-24 9:40 ` Petr Baudis
2013-05-24 10:06 ` John Keeping
2013-05-24 10:14 ` Petr Baudis
2013-05-24 10:40 ` John Keeping
2013-05-24 11:03 ` Petr Baudis
2013-05-24 12:42 ` John Keeping [this message]
2013-05-24 14:26 ` Stephen Bash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524124242.GD27005@serenity.lan \
--to=john@keeping.me.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=james.a.greenleaf@gmail.com \
--cc=pasky@ucw.cz \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).