From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Karsten Blees <karsten.blees@gmail.com>,
Pat Thoyts <patthoyts@gmail.com>,
msysGit <msysgit@googlegroups.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Sebastian Schuberth <sschuberth@gmail.com>,
Git List <git@vger.kernel.org>, Adam Spiers <git@adamspiers.org>
Subject: Re: t0008-ignores failure
Date: Wed, 29 May 2013 22:55:54 -0400 [thread overview]
Message-ID: <20130530025554.GC19860@sigill.intra.peff.net> (raw)
In-Reply-To: <20130530025258.GB19860@sigill.intra.peff.net>
On Wed, May 29, 2013 at 10:52:58PM -0400, Jeff King wrote:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index ca6bdef..5d84705 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -600,7 +600,7 @@ fi
> fi
>
> # Test repository
> -TRASH_DIRECTORY="trash directory.$(basename "$0" .sh)"
> +TRASH_DIRECTORY="trash directory:$(basename "$0" .sh)"
> test -n "$root" && TRASH_DIRECTORY="$root/$TRASH_DIRECTORY"
> case "$TRASH_DIRECTORY" in
> /*) ;; # absolute path is good
>
> reveals the breakage on Linux. And it seems that a lot of other tests
> break, too. I haven't looked into them yet, though.
Hrm. Just picking an example at random, t7006 fails because it uses
--exec-path="`pwd`". And of course colons are meaningful in any
PATH-like context. It would be nice to be able to handle that case
cleanly, but I think we would be breaking compatibility.
So while it would be nice to work on paths with colons everywhere, I
doubt it is worth the effort to start checking it through the whole test
suite.
-Peff
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
next prev parent reply other threads:[~2013-05-30 2:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABNJ2G+u96P+_=Q7it0KbK9E01qunz7XZ7e3zCZvaTaOUuTQqQ@mail.gmail.com>
2013-05-30 1:13 ` t0008-ignores failure (was: Git for Windows 1.8.3) Karsten Blees
2013-05-30 2:21 ` t0008-ignores failure Junio C Hamano
2013-05-30 2:52 ` Jeff King
2013-05-30 2:55 ` Jeff King [this message]
2013-05-30 6:58 ` Johannes Sixt
2013-05-30 15:15 ` t0008-ignores failure (was: Git for Windows 1.8.3) Johannes Schindelin
2013-05-30 15:45 ` Pat Thoyts
2013-05-30 17:14 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530025554.GC19860@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@adamspiers.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karsten.blees@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@gmail.com \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).