git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Fleischer <git@cryptocrack.de>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org, Antoine Pelisse <apelisse@gmail.com>
Subject: Re: t4015 broken on pu
Date: Mon, 3 Jun 2013 21:11:38 +0200	[thread overview]
Message-ID: <20130603191138.GA16172@blizzard> (raw)
In-Reply-To: <51ACE819.3010704@web.de>

On Mon, Jun 03, 2013 at 09:01:45PM +0200, Torsten Bögershausen wrote:
> The new 4015 does not pass under Mac OS:
> 
> a) The seq command, does not exits (we can use printf)
> [...]
> diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh
> index b3c4fcc..f00d20b 100755
> --- a/t/t4015-diff-whitespace.sh
> +++ b/t/t4015-diff-whitespace.sh
> @@ -143,18 +143,18 @@ git diff --ignore-space-at-eol > out
>  test_expect_success 'another test, with --ignore-space-at-eol' 'test_cmp expect out'
>  
>  test_expect_success 'ignore-blank-lines: only new lines' '
> -       seq 5 >x &&
> +       printf "1\n2\n3\n4\n5\n" >x &&

I'd rather use test_seq here.

>         git update-index x &&
> -       seq 5 | sed "/3/i \\\\" >x &&
> +       printf "1\n2\n3\n4\n5\n" | sed "/3/i \\\\" >x &&
>         git diff --ignore-blank-lines >out &&
> [...]

      parent reply	other threads:[~2013-06-03 19:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 19:01 t4015 broken on pu Torsten Bögershausen
2013-06-03 19:07 ` Antoine Pelisse
2013-06-03 19:11 ` Lukas Fleischer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130603191138.GA16172@blizzard \
    --to=git@cryptocrack.de \
    --cc=apelisse@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).