From: Jeff King <peff@peff.net>
To: Ian Kumlien <pomac@vapor.com>
Cc: git@vger.kernel.org
Subject: Re: git-daemon: needs /root/.config/git/config?
Date: Wed, 5 Jun 2013 11:43:45 -0400 [thread overview]
Message-ID: <20130605154344.GA8664@sigill.intra.peff.net> (raw)
In-Reply-To: <20130605111918.GE22308@pomac.netswarm.net>
On Wed, Jun 05, 2013 at 01:19:18PM +0200, Ian Kumlien wrote:
> > Older versions of git silently ignored errors reading config files, but
> > it was tightened in v1.8.1.1, as there can be quite serious implications
> > to failing to read expected config (e.g., imagine transfer.fsckobjects,
> > or receive.deny* is ignored).
>
> Yes, i agree, it's suboptimal but I for one would use getpwuid to get
> the home directory of the executing user to avoid this - though i don't
> know how portable it is (or if there is any other issues)
We considered having git-daemon's "--user" option do that, but:
1. It would be a regression for people who are intentionally setting
HOME to get different config profiles. And it would be a surprise
to admins, as other user-switching daemons (e.g., inetd) do not
tweak HOME.
2. It would not have covered all cases, including yours. xinetd is the
one doing the user-switching here.
-Peff
next prev parent reply other threads:[~2013-06-05 15:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 14:13 git-daemon: needs /root/.config/git/config? Ian Kumlien
2013-06-04 16:08 ` Jeff King
2013-06-04 19:05 ` Johannes Sixt
2013-06-04 19:10 ` Jonathan Nieder
2013-06-04 19:20 ` Junio C Hamano
2013-06-04 21:06 ` Jeff King
2013-06-04 21:24 ` Junio C Hamano
2013-06-05 11:19 ` Ian Kumlien
2013-06-05 11:43 ` Andreas Krey
2013-06-05 15:43 ` Jeff King [this message]
2013-06-09 12:47 ` Bernhard R. Link
2013-06-10 12:06 ` Ian Kumlien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605154344.GA8664@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pomac@vapor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).