git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2013, #03; Thu, 6)
Date: Fri, 7 Jun 2013 21:16:43 +0200	[thread overview]
Message-ID: <20130607191643.GA31625@goldbirke> (raw)
In-Reply-To: <7v8v2lu5ks.fsf@alter.siamese.dyndns.org>

On Fri, Jun 07, 2013 at 11:41:07AM -0700, Junio C Hamano wrote:
> "git log -Gcomplete_file -p contrib/completion" found this one:
> 
> commit 1d66ec587e7d903afdf12a81718772a9eadc15a1
> Author: SZEDER Gábor <szeder@ira.uka.de>
> Date:   Thu Mar 10 19:12:29 2011 +0100
> 
>     bash: complete 'git diff ...branc<TAB>'

(snip)

>     Suggested-by: Junio C Hamano <gitster@pobox.com>
>     Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
>     Signed-off-by: Junio C Hamano <gitster@pobox.com>
> 
> Now I do not recall suggesting it, and you (and I today after 2
> years) may disagree with the rationale, but at least we can read
> what was the "intended" meaning, I think.

See

  http://thread.gmane.org/gmane.comp.version-control.git/167728/focus=168838

I still agree with the rationale, considering that the new
__git_complete_revlist_file() function for completing ref1...ref2:path
is a nearly straight copy-paste from the then __git_complete_revlist()
and __git_complete_file() including that 12 line long sed script.


Gábor

  parent reply	other threads:[~2013-06-07 19:16 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06 22:41 What's cooking in git.git (Jun 2013, #03; Thu, 6) Junio C Hamano
2013-06-07  0:00 ` SZEDER Gábor
2013-06-07  1:05   ` Junio C Hamano
2013-06-07 15:57     ` Junio C Hamano
2013-06-07 19:34     ` SZEDER Gábor
2013-06-07 19:47       ` Ramkumar Ramachandra
2013-06-07 20:06         ` SZEDER Gábor
2013-06-07 17:30   ` Ramkumar Ramachandra
2013-06-07 18:41     ` Junio C Hamano
2013-06-07 19:01       ` Ramkumar Ramachandra
2013-06-07 19:16       ` SZEDER Gábor [this message]
2013-06-07 19:46         ` Junio C Hamano
2013-06-07 20:44           ` SZEDER Gábor
2013-06-07 21:53             ` Junio C Hamano
2013-06-08  0:11               ` SZEDER Gábor
2013-06-09 21:20                 ` Junio C Hamano
2013-06-09 21:48                   ` SZEDER Gábor
2013-06-09 22:56                     ` Junio C Hamano
2013-06-10  6:25                   ` Ramkumar Ramachandra
2013-06-10  7:00                     ` Junio C Hamano
2013-06-10  7:41                       ` Ramkumar Ramachandra
2013-06-07 18:55     ` SZEDER Gábor
2013-06-08 15:30 ` Ramkumar Ramachandra
2013-06-08 18:39   ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130607191643.GA31625@goldbirke \
    --to=szeder@ira.uka.de \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).