From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH] completion: add deprecated __git_complete_file ()
Date: Sat, 8 Jun 2013 02:24:52 +0200 [thread overview]
Message-ID: <20130608002452.GE31625@goldbirke> (raw)
In-Reply-To: <7vobbhsll3.fsf@alter.siamese.dyndns.org>
On Fri, Jun 07, 2013 at 01:38:16PM -0700, Junio C Hamano wrote:
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
> > 77c130 (completion: clarify ls-tree, archive, show completion,
> > 2013-06-02) removed __git_complete_file () because it had no callers
> > left in the file. However, to avoid breaking user scripts that may
> > depend on this, add it back as a deprecated alias.
> >
> > Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> > ---
> > Based on pu.
>
> Will queue; thanks. With this, I think it will be safe to push the
> series in question to 'master'.
Safe? Yes, at least scripts won't break because of the missing
function.
However, I still think it would be worth reverting at least the hunks
modifying the completion functions of ls-tree and archive. Or better
yet, the whole series.
prev parent reply other threads:[~2013-06-08 0:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 19:09 [PATCH] completion: add deprecated __git_complete_file () Ramkumar Ramachandra
2013-06-07 19:25 ` Felipe Contreras
2013-06-07 19:29 ` Ramkumar Ramachandra
2013-06-07 19:31 ` Felipe Contreras
2013-06-08 0:35 ` SZEDER Gábor
2013-06-07 20:38 ` Junio C Hamano
2013-06-08 0:24 ` SZEDER Gábor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130608002452.GE31625@goldbirke \
--to=szeder@ira.uka.de \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox