From: Ian Kumlien <pomac@vapor.com>
To: "Bernhard R. Link" <brl+git@mail.brlink.eu>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: git-daemon: needs /root/.config/git/config?
Date: Mon, 10 Jun 2013 14:06:53 +0200 [thread overview]
Message-ID: <20130610120653.GA14168@pomac.netswarm.net> (raw)
In-Reply-To: <20130609124757.GA3347@client.brlink.eu>
On Sun, Jun 09, 2013 at 02:47:57PM +0200, Bernhard R. Link wrote:
> * Ian Kumlien <pomac@vapor.com> [130605 13:31]:
> > Yes, i agree, it's suboptimal but I for one would use getpwuid to get
> > the home directory of the executing user to avoid this - though i don't
> > know how portable it is (or if there is any other issues)
>
> It's not only suboptimal but simply wrong. getpwuid gives at best the
> initial home directory, and even there it is only a guess. (If you are
> looking for some home directory of a different user it might be a good
> guess). But using getpwuid(getuid())->pw_dir if HOME is set is a serious
> mistake, as you throw out the good value for some almost but not quite
> totally unrelated value.
Well i never intended for it to replace the environment variable, it was
more intended as a fallback - if there will be a "less strict" mode then
perhaps a fallback would be a more controled way of doing it.
> Bernhard R. Link
prev parent reply other threads:[~2013-06-10 12:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 14:13 git-daemon: needs /root/.config/git/config? Ian Kumlien
2013-06-04 16:08 ` Jeff King
2013-06-04 19:05 ` Johannes Sixt
2013-06-04 19:10 ` Jonathan Nieder
2013-06-04 19:20 ` Junio C Hamano
2013-06-04 21:06 ` Jeff King
2013-06-04 21:24 ` Junio C Hamano
2013-06-05 11:19 ` Ian Kumlien
2013-06-05 11:43 ` Andreas Krey
2013-06-05 15:43 ` Jeff King
2013-06-09 12:47 ` Bernhard R. Link
2013-06-10 12:06 ` Ian Kumlien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610120653.GA14168@pomac.netswarm.net \
--to=pomac@vapor.com \
--cc=brl+git@mail.brlink.eu \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).