From: Charles McGarvey <chazmcgarvey@brokenzipper.com>
To: git@vger.kernel.org
Subject: [PATCH] instaweb: make the perl path configurable
Date: Tue, 11 Jun 2013 14:14:05 -0600 [thread overview]
Message-ID: <20130611201400.GA28010@compy.Home> (raw)
It is convenient for the user to be able to customize the path to perl if they
do not want to use the system perl. This may be the case, for example, if the
user wants to use the plackup httpd but its extra dependencies are not
installed in the system perl; they can set the perl path to a perl that they
install and have control over in their own home directory.
Signed-off-by: Charles McGarvey <chazmcgarvey@brokenzipper.com>
---
Documentation/config.txt | 4 ++++
git-instaweb.sh | 4 +++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index 6e53fc5..e103594 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -1549,6 +1549,10 @@ instaweb.modulepath::
instead of /usr/lib/apache2/modules. Only used if httpd
is Apache.
+instaweb.perlpath::
+ The path to the perl executable used by linkgit:git-instaweb[1] to
+ run gitweb and/or verify that the HTTP daemon is running.
+
instaweb.port::
The port number to bind the gitweb httpd to. See
linkgit:git-instaweb[1].
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 01a1b05..8cfbdf2 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -3,7 +3,6 @@
# Copyright (c) 2006 Eric Wong
#
-PERL='@@PERL@@'
OPTIONS_KEEPDASHDASH=
OPTIONS_SPEC="\
git instaweb [options] (--start | --stop | --restart)
@@ -26,9 +25,12 @@ local="$(git config --bool --get instaweb.local)"
httpd="$(git config --get instaweb.httpd)"
root="$(git config --get instaweb.gitwebdir)"
port=$(git config --get instaweb.port)
+perl_path="$(git config --get instaweb.perlpath)"
module_path="$(git config --get instaweb.modulepath)"
action="browse"
+PERL=${perl_path:-@@PERL@@}
+
conf="$GIT_DIR/gitweb/httpd.conf"
# Defaults:
--
1.8.1.5
next reply other threads:[~2013-06-11 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 20:14 Charles McGarvey [this message]
2013-06-12 14:00 ` [PATCH] instaweb: make the perl path configurable Jakub Narebski
2013-06-12 18:48 ` Charles McGarvey
2013-06-12 21:03 ` Jakub Narębski
2013-06-12 23:13 ` Charles McGarvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130611201400.GA28010@compy.Home \
--to=chazmcgarvey@brokenzipper.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).