git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tests: allow sha1's as part of the path
@ 2013-06-15 21:35 Dennis Kaarsemaker
  2013-06-17 19:59 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Dennis Kaarsemaker @ 2013-06-15 21:35 UTC (permalink / raw)
  To: git; +Cc: jrnieder

When running 'make test' from a path such as
.../daily-build/master@bdff0e3a374617dce784f801b97500d9ba2e4705, the
logic in fuzz.sed as generated by t5105-request-pull.sh was backwards,
replacing object names before replacing urls, making the test fail.

Signed-off-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>
---
 t/t5150-request-pull.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh
index 432f98c..1afa0d5 100755
--- a/t/t5150-request-pull.sh
+++ b/t/t5150-request-pull.sh
@@ -80,12 +80,12 @@ test_expect_success 'setup: two scripts for reading pull requests' '
 
 	cat <<-EOT >fuzz.sed
 	#!/bin/sed -nf
+	s/$downstream_url_for_sed/URL/g
 	s/$_x40/OBJECT_NAME/g
 	s/A U Thor/AUTHOR/g
 	s/[-0-9]\{10\} [:0-9]\{8\} [-+][0-9]\{4\}/DATE/g
 	s/        [^ ].*/        SUBJECT/g
 	s/  [^ ].* (DATE)/  SUBJECT (DATE)/g
-	s/$downstream_url_for_sed/URL/g
 	s/for-upstream/BRANCH/g
 	s/mnemonic.txt/FILENAME/g
 	s/^version [0-9]/VERSION/
-- 
1.8.2.4.g940421e

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tests: allow sha1's as part of the path
  2013-06-15 21:35 [PATCH] tests: allow sha1's as part of the path Dennis Kaarsemaker
@ 2013-06-17 19:59 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2013-06-17 19:59 UTC (permalink / raw)
  To: Dennis Kaarsemaker; +Cc: git, jrnieder

Makes sense; thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-17 20:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-15 21:35 [PATCH] tests: allow sha1's as part of the path Dennis Kaarsemaker
2013-06-17 19:59 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).