git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Phil Hord <hordp@cisco.com>
Cc: git@vger.kernel.org, phil.hord@gmail.com,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] fix "builtin-*" references to be "builtin/*"
Date: Tue, 18 Jun 2013 09:28:23 -0700	[thread overview]
Message-ID: <20130618162823.GB2887@elie.Belkin> (raw)
In-Reply-To: <1371571166-6481-1-git-send-email-hordp@cisco.com>

Hi,

Phil Hord wrote:

> Documentation and some comments still refer to files in builtin/
> as 'builtin-*.[cho]'.  Update these to show the correct location.

Yeah, good call.

[...]
> --- a/builtin/help.c
> +++ b/builtin/help.c
> @@ -1,5 +1,5 @@
>  /*
> - * builtin-help.c
> + * builtin/help.c
>   *

It would probably be better to remove the above two lines which are
redundant next to the filename.  That can wait for a later patch if
you like, though.

With or without that change,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

  reply	other threads:[~2013-06-18 16:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18 15:59 [PATCH] fix "builtin-*" references to be "builtin/*" Phil Hord
2013-06-18 16:28 ` Jonathan Nieder [this message]
2013-06-18 17:06 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130618162823.GB2887@elie.Belkin \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hordp@cisco.com \
    --cc=phil.hord@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).