From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2 2/2] send-email: add test for duplicate utf8 name Date: Thu, 20 Jun 2013 15:53:29 +0300 Message-ID: <20130620125329.GA24236@redhat.com> References: <1371731166-24015-1-git-send-email-mst@redhat.com> <1371731166-24015-2-git-send-email-mst@redhat.com> <87a9ml9cou.fsf@linux-k42r.v.cablecom.net> <20130620124502.GA24172@redhat.com> <87vc597xtc.fsf@linux-k42r.v.cablecom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org, SZEDER =?iso-8859-1?Q?G=E1bor?= To: Thomas Rast X-From: git-owner@vger.kernel.org Thu Jun 20 14:53:00 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UpeMF-0004ay-9N for gcvg-git-2@plane.gmane.org; Thu, 20 Jun 2013 14:52:59 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757852Ab3FTMwz (ORCPT ); Thu, 20 Jun 2013 08:52:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33916 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754811Ab3FTMwy (ORCPT ); Thu, 20 Jun 2013 08:52:54 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5KCqiKw025354 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 20 Jun 2013 08:52:44 -0400 Received: from redhat.com (vpn-200-33.tlv.redhat.com [10.35.200.33]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id r5KCqfRr012249; Thu, 20 Jun 2013 08:52:43 -0400 Content-Disposition: inline In-Reply-To: <87vc597xtc.fsf@linux-k42r.v.cablecom.net> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Jun 20, 2013 at 02:48:15PM +0200, Thomas Rast wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Jun 20, 2013 at 02:41:37PM +0200, Thomas Rast wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > Verify that author name is not duplicated if it matches > >> > sender, even if it is in utf8. > >> > >> Small nit: if you make two patches out of it, add the tests first with > >> test_expect_failure. Then flip it to test_expect_success in the actual > >> code change. That makes it easy to verify that the test actually checks > >> the right thing, and that it was your code change that fixed it. > > > > I did this by reverting 1/2 and rerunning. > > > > But applying in reverse order means bisect can give us > > a setup where some tests fail, I thought it's a > > good idea to avoid that. > > That's why you need to test_expect_*failure* in the commit that adds the > tests -- essentially saying "I know this is broken!". > > Yes, it's a roundabout way. But splitting code and tests in the way you > just posted is equally roundabout, while not having the benefit that one > can check out the commit at patch 1 and verify that it is indeed broken > (showing up as "still have known breakage"). I'll try to do it like this next time, I hope for now Junio can take it as is. > -- > Thomas Rast > trast@{inf,student}.ethz.ch