From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Eduardo D'Avila <erdavila@gmail.com>
Cc: git@vger.kernel.org,
Felipe Contreras <felipe.contreras@gmail.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Simon Oosthoek <s.oosthoek@xs4all.nl>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/4] t9903: add tests for git-prompt pcmode
Date: Mon, 24 Jun 2013 18:21:34 +0200 [thread overview]
Message-ID: <20130624162134.GA2136@goldbirke> (raw)
In-Reply-To: <CAOz-D1L3mrqTKwpnRVEEfZayFNX+eKVNC1-Ewy45tmf9MPQhtQ@mail.gmail.com>
On Sat, Jun 22, 2013 at 01:32:38PM -0300, Eduardo D'Avila wrote:
> These tests where important to make sure that I wouldn't break anything during
> the refactorization. Having them pass before *and* after refactorization
> guarantees that nothing was broken (except for some subtle case that might have
> not be included in the tests).
>
> However, I agree that they became redundant.
>
> Would it make sense to include a patch that only removes the zsh
> tests, after the
> refactorization?
That would be fine with me.
Thanks,
Gábor
next prev parent reply other threads:[~2013-06-24 16:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 2:25 [PATCH 0/4] git-prompt: cleaning and improvement Eduardo R. D'Avila
2013-06-21 2:25 ` [PATCH 1/4] t9903: add tests for git-prompt pcmode Eduardo R. D'Avila
2013-06-22 13:06 ` SZEDER Gábor
2013-06-22 16:32 ` Eduardo D'Avila
2013-06-23 7:39 ` Junio C Hamano
2013-06-24 16:21 ` SZEDER Gábor [this message]
2013-06-21 2:25 ` [PATCH 2/4] git-prompt.sh: refactor colored prompt code Eduardo R. D'Avila
2013-06-22 14:37 ` Øystein Walle
2013-06-22 16:45 ` Eduardo D'Avila
2013-06-23 14:51 ` SZEDER Gábor
2013-06-25 1:21 ` Eduardo R. D'Avila
2013-06-21 2:25 ` [PATCH 3/4] git-prompt.sh: do not print duplicate clean color code Eduardo R. D'Avila
2013-06-22 13:26 ` SZEDER Gábor
2013-06-21 2:25 ` [PATCH 4/4] git-prompt.sh: add missing information in comments Eduardo R. D'Avila
2013-06-22 13:40 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624162134.GA2136@goldbirke \
--to=szeder@ira.uka.de \
--cc=artagnon@gmail.com \
--cc=erdavila@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=s.oosthoek@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).