From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] format-patch handling in-body From headers
Date: Wed, 3 Jul 2013 05:03:52 -0400 [thread overview]
Message-ID: <20130703090352.GA20749@sigill.intra.peff.net> (raw)
In-Reply-To: <7vd2r0ggup.fsf@alter.siamese.dyndns.org>
On Wed, Jul 03, 2013 at 01:58:22AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > However, doing it right is kind of tricky due to rfc822 quoting, rfc2047
> > encoding, and handling non-ascii names correctly. Instead, this patch
> > series takes a different approach: it teaches format-patch to do the
> > transformation itself, so that it can be used by my script along with
> > any other non-send-email workflows that exist (e.g., git-imap-send
> > suffers from the same problem).
>
> I think the original expectation when format-patch was done was to
> use Sender: to identify you while keeping the author on From:, but
> with the current world order to use in-body header, this addition
> makes sense.
Yeah, I think using "Sender" would simply be too confusing, as most MUAs
show only the "From", and authors of patches do not necessarily know or
care about the mailing of their patch.
> I wonder if we can lose some code from send-email then?
Potentially, as long as we default to "--from" to turn this feature on
all the time (otherwise we are breaking the existing "format-patch &&
send-email" workflow).
It may also confuse people who mark up the patches on disk before
running send-email. I don't know if people actually change the From
header there or not.
-Peff
prev parent reply other threads:[~2013-07-03 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 7:07 [PATCH 0/2] format-patch handling in-body From headers Jeff King
2013-07-03 7:07 ` [PATCH 1/2] pretty.c: drop const-ness from pretty_print_context Jeff King
2013-07-03 7:08 ` [PATCH 2/2] teach format-patch to place other authors into in-body "From" Jeff King
2013-07-03 7:21 ` Eric Sunshine
2013-07-03 8:58 ` [PATCH 0/2] format-patch handling in-body From headers Junio C Hamano
2013-07-03 9:03 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703090352.GA20749@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).