From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/4] describe: use argv-array
Date: Tue, 9 Jul 2013 14:53:38 -0400 [thread overview]
Message-ID: <20130709185338.GA5153@sigill.intra.peff.net> (raw)
In-Reply-To: <7vehb7wwob.fsf@alter.siamese.dyndns.org>
On Tue, Jul 09, 2013 at 09:00:20AM -0700, Junio C Hamano wrote:
> >>> + return cmd_name_rev(args.argc, args.argv, prefix);
> >>
> >> This leaks the memory allocated by "args". The original did, too, and it
> >> is probably not that big a deal (we exit right after anyway). The fix
> >> would be something like:
> >>
> >> rc = cmd_name_rev(args.argc, args.argv, prefix);
> >> argv_array_clear(&args);
> >> return rc;
> >
> > Yes; this was meant as a straight rewrite and I did not bother, but
> > I should have cleaned it up as I meant to build on top.
> >
> > Will amend, even though I do not think we need to build anything on
> > top.
>
> Heh, you fooled me. cmd_name_rev() uses the usual parse-options
> machinery that updates args.argv[]. Dashed options that were
> consumed will not remain in args.argv[] and argv_array_clear() will
> not have a chance to free them, and besides, args.argc and args.argv
> will be out of sync and wreaks havoc in argv_array_clear().
Ick, yeah, I forgot about that. Let's just leave it as a leak, then. We
are exiting immediately afterwards, anyway.
-Peff
next prev parent reply other threads:[~2013-07-09 18:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 22:33 [PATCH 0/4] Make "git name-rev $(git rev-parse v1.8.3)" work Junio C Hamano
2013-07-07 22:33 ` [PATCH 1/4] name-ref: factor out name shortening logic from name_ref() Junio C Hamano
2013-07-08 8:52 ` Michael Haggerty
2013-07-08 15:04 ` Junio C Hamano
2013-07-07 22:33 ` [PATCH 2/4] name-rev: allow converting the exact object name at the tip of a ref Junio C Hamano
2013-07-08 12:20 ` Ramkumar Ramachandra
2013-07-08 15:12 ` Junio C Hamano
2013-07-07 22:33 ` [PATCH 3/4] describe: use argv-array Junio C Hamano
2013-07-09 4:51 ` Jeff King
2013-07-09 14:55 ` Junio C Hamano
2013-07-09 16:00 ` Junio C Hamano
2013-07-09 18:53 ` Jeff King [this message]
2013-07-07 22:33 ` [PATCH 4/4] describe/name-rev: tell name-rev to peel the incoming object to commit first Junio C Hamano
2013-07-08 13:08 ` Ramkumar Ramachandra
2013-07-09 5:12 ` Jeff King
2013-07-09 5:06 ` Jeff King
2013-07-09 5:33 ` Junio C Hamano
2013-07-09 5:35 ` Jeff King
2013-07-09 11:45 ` Junio C Hamano
2013-07-09 12:42 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709185338.GA5153@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).