From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Heiko Voigt <hvoigt@hvoigt.net>,
git@vger.kernel.org, Jens Lehmann <jens.lehmann@web.de>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: [PATCH v5 0/5] allow more sources for config values
Date: Fri, 12 Jul 2013 06:10:53 -0400 [thread overview]
Message-ID: <20130712101052.GA6024@sigill.intra.peff.net> (raw)
In-Reply-To: <7vk3kwptkl.fsf@alter.siamese.dyndns.org>
On Thu, Jul 11, 2013 at 04:26:02PM -0700, Junio C Hamano wrote:
> Thanks.
>
> The differences since the last round I see are these. And I think
> the series overall makes sense (I haven't look hard enough to pick
> any nits yet, though).
Both v4 and the interdiff look fine to me. I gave it one more cursory
read-through, and I don't see any problems. So:
Acked-by: Jeff King <peff@peff.net>
-Peff
prev parent reply other threads:[~2013-07-12 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 22:36 [PATCH v5 0/5] allow more sources for config values Heiko Voigt
2013-07-11 22:40 ` [PATCH v5 1/5] config: factor out config file stack management Heiko Voigt
2013-07-11 22:43 ` [PATCH v5 2/5] config: drop cf validity check in get_next_char() Heiko Voigt
2013-07-11 22:44 ` [PATCH v5 3/5] config: make parsing stack struct independent from actual data source Heiko Voigt
2013-07-11 22:46 ` [PATCH v5 4/5] teach config --blob option to parse config from database Heiko Voigt
2013-07-11 22:48 ` [PATCH v5 5/5] do not die when error in config parsing of buf occurs Heiko Voigt
2013-07-11 23:26 ` [PATCH v5 0/5] allow more sources for config values Junio C Hamano
2013-07-12 10:10 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712101052.GA6024@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jens.lehmann@web.de \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).