From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/7] cat-file --batch-check performance improvements
Date: Fri, 12 Jul 2013 16:12:54 -0400 [thread overview]
Message-ID: <20130712201254.GA5276@sigill.intra.peff.net> (raw)
In-Reply-To: <7vy59blmjt.fsf@alter.siamese.dyndns.org>
On Fri, Jul 12, 2013 at 10:23:34AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > The results for running (in linux.git):
> >
> > $ git rev-list --objects --all >objects
> > $ git cat-file --batch-check='%(objectsize:disk)' <objects >/dev/null
>
> I can see how these patches are very logical avenue to grab only
> on-disk footprint for large number of objects, but among the type,
> payload size and on-disk footprint, I find it highly narrow niche
> that a real user or script is interested _only_ in on-disk footprint
> without even worrying about the type of object.
Yeah, I agree it is a bit of a niche. However, there are other code
paths that might want only the size and not the type (e.g., we already
know the object is a blob, but want to know size before deciding how to
handle diff). But in general, I doubt the performance impact is a big
deal there. It's only measurable when you're doing millions of objects.
-Peff
prev parent reply other threads:[~2013-07-12 20:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 6:15 [PATCH 0/7] cat-file --batch-check performance improvements Jeff King
2013-07-12 6:20 ` [PATCH 1/7] cat-file: disable object/refname ambiguity check for batch mode Jeff King
2013-07-12 8:47 ` Michael Haggerty
2013-07-12 9:22 ` Jeff King
2013-07-12 10:30 ` Michael Haggerty
2013-07-15 4:23 ` Jeff King
2013-07-15 3:45 ` Junio C Hamano
2013-07-15 4:17 ` Jeff King
2013-07-12 6:21 ` [PATCH 2/7] sha1_object_info_extended: rename "status" to "type" Jeff King
2013-07-12 6:30 ` [PATCH 3/7] sha1_loose_object_info: make type lookup optional Jeff King
2013-07-12 6:31 ` [PATCH 4/7] packed_object_info: hoist delta type resolution to helper Jeff King
2013-07-12 6:32 ` [PATCH 5/7] packed_object_info: make type lookup optional Jeff King
2013-07-12 6:34 ` [PATCH 6/7] sha1_object_info_extended: make type calculation optional Jeff King
2013-07-12 6:37 ` [PATCH 7/7] sha1_object_info_extended: pass object_info to helpers Jeff King
2013-07-12 17:23 ` [PATCH 0/7] cat-file --batch-check performance improvements Junio C Hamano
2013-07-12 20:12 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712201254.GA5276@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).