From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] Add the GIT_SENTINEL macro
Date: Thu, 18 Jul 2013 16:31:51 -0400 [thread overview]
Message-ID: <20130718203150.GA15735@sigill.intra.peff.net> (raw)
In-Reply-To: <51E849C4.7020305@ramsay1.demon.co.uk>
On Thu, Jul 18, 2013 at 09:02:12PM +0100, Ramsay Jones wrote:
> The sentinel function attribute is not understood by versions of
> the gcc compiler prior to v4.0. At present, for earlier versions
> of gcc, the build issues 108 warnings related to the unknown
> attribute. In order to suppress the warnings, we conditionally
> define the GIT_SENTINEL macro to provide the sentinel attribute
> for gcc v4.0 and newer.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
Acked-by: Jeff King <peff@peff.net>
> -__attribute__((sentinel))
> +GIT_SENTINEL(0)
> void argv_array_pushl(struct argv_array *, ...);
We could also add GIT_SENTINEL to handle the default-zero case, but I do
not think it is worth the trouble.
-Peff
next prev parent reply other threads:[~2013-07-18 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 20:02 [PATCH] Add the GIT_SENTINEL macro Ramsay Jones
2013-07-18 20:31 ` Jeff King [this message]
2013-07-18 21:06 ` Jonathan Nieder
2013-07-19 3:30 ` Junio C Hamano
2013-07-19 3:36 ` Jonathan Nieder
2013-07-19 7:18 ` Junio C Hamano
2013-07-20 19:13 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130718203150.GA15735@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).