git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] push: fix typo in advice message
@ 2013-07-29  4:23 Ralf Thielow
  2013-07-29  4:55 ` Jeff King
  0 siblings, 1 reply; 2+ messages in thread
From: Ralf Thielow @ 2013-07-29  4:23 UTC (permalink / raw)
  To: git; +Cc: gitster, Ralf Thielow

Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
---
 builtin/push.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/push.c b/builtin/push.c
index 6d36c24..04abd2d 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -250,7 +250,7 @@ static const char message_advice_ref_fetch_first[] =
 	N_("Updates were rejected because the remote contains work that you do\n"
 	   "not have locally. This is usually caused by another repository pushing\n"
 	   "to the same ref. You may want to first integrate the remote changes\n"
-	   "(e.g., 'git pull ...') before pushing again.\n"
+	   "(e.g. 'git pull ...') before pushing again.\n"
 	   "See the 'Note about fast-forwards' in 'git push --help' for details.");
 
 static const char message_advice_ref_already_exists[] =
-- 
1.8.2.1873.gfc589a4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] push: fix typo in advice message
  2013-07-29  4:23 [PATCH] push: fix typo in advice message Ralf Thielow
@ 2013-07-29  4:55 ` Jeff King
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2013-07-29  4:55 UTC (permalink / raw)
  To: Ralf Thielow; +Cc: git, gitster

On Mon, Jul 29, 2013 at 06:23:52AM +0200, Ralf Thielow wrote:

> Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
> ---
>  builtin/push.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/builtin/push.c b/builtin/push.c
> index 6d36c24..04abd2d 100644
> --- a/builtin/push.c
> +++ b/builtin/push.c
> @@ -250,7 +250,7 @@ static const char message_advice_ref_fetch_first[] =
>  	N_("Updates were rejected because the remote contains work that you do\n"
>  	   "not have locally. This is usually caused by another repository pushing\n"
>  	   "to the same ref. You may want to first integrate the remote changes\n"
> -	   "(e.g., 'git pull ...') before pushing again.\n"
> +	   "(e.g. 'git pull ...') before pushing again.\n"

I do not think the comma is a typo. In American English it is usually
preferred, but googling "comma after e.g." seems to indicate that it is
not in British English.

Grep shows that we use both styles in quite a few places.

-Peff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-29  4:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-29  4:23 [PATCH] push: fix typo in advice message Ralf Thielow
2013-07-29  4:55 ` Jeff King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).