From: John Keeping <john@keeping.me.uk>
To: "Dale R. Worley" <worley@alum.mit.edu>
Cc: git@vger.kernel.org
Subject: Re: Making a patch: "git format-patch" does not produce the documented format
Date: Wed, 31 Jul 2013 22:48:19 +0100 [thread overview]
Message-ID: <20130731214818.GP2337@serenity.lan> (raw)
In-Reply-To: <201307312131.r6VLVliK028321@hobgoblin.ariadne.com>
On Wed, Jul 31, 2013 at 05:31:47PM -0400, Dale R. Worley wrote:
> Notice that the whole commit message has been formatted as if it is
> part of the Subject line, and the line breaks in the commit message
> have been refilled.
>
> The file Documentation/SubmittingPatches says that "git format-patch"
> produces patches in the best format, but the manual page shows an
> example more like this:
>
> From 8f72bad1baf19a53459661343e21d6491c3908d3 Mon Sep 17 00:00:00 2001
> From: Tony Luck <tony.luck@intel.com>
> Date: Tue, 13 Jul 2010 11:42:54 -0700
> Subject: [PATCH] Put ia64 config files on the
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> arch/arm config files were slimmed down using a python script
> (See commit c2330e286f68f1c408b4aa6515ba49d57f05beae comment)
> [...]
>
> That is, the first line of the commit message is in the Subject and
> the remaining lines are in the message body. As far as I can tell,
> that's what SubmittingPatches prescribes. And that is what I see in
> the Git mailing list on vger.
>
> (This is with git 1.8.3.3.)
>
> Exactly how should the commit message be inserted into the patch
> e-mail? What needs to be updated so the code is consistent with the
> documentation?
git-format-patch(1) says:
By default, the subject of a single patch is "[PATCH] " followed
by the concatenation of lines from the commit message up to the
first blank line (see the DISCUSSION section of git-commit(1)).
I think that accurately describes what you're seeing. The referenced
DISCUSSION section describes how to write a commit message that is
formatted in a suitable way, with a short first subject line and then a
blank line before the body of the message.
next prev parent reply other threads:[~2013-07-31 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 21:31 Making a patch: "git format-patch" does not produce the documented format Dale R. Worley
2013-07-31 21:48 ` John Keeping [this message]
2013-08-02 22:11 ` Dale R. Worley
2013-08-02 23:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731214818.GP2337@serenity.lan \
--to=john@keeping.me.uk \
--cc=git@vger.kernel.org \
--cc=worley@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).