From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Thorsten Glaser <tg@mirbsd.de>,
git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: Re: git should not use a default user.email config value
Date: Sat, 10 Aug 2013 03:14:07 -0400 [thread overview]
Message-ID: <20130810071407.GA32038@sigill.intra.peff.net> (raw)
In-Reply-To: <20130810070300.GB3165@elie.Belkin>
On Sat, Aug 10, 2013 at 12:03:00AM -0700, Jonathan Nieder wrote:
> Jeff King wrote:
>
> > Sorry to be unclear. I meant that treating /etc/mailname and gethostname
> > differently might be justified on Debian under the logic "if you have
> > /etc/mailname, that is a trustworthy address, and if you do not, then we
> > cannot guess at a trustworthy address (because putting it in
> > /etc/mailname is the accepted way to do so on Debian)".
> >
> > But such logic would not extend to other operating systems, where
> > /etc/mailname does not have such a status.
>
> I thought that on other operating systems people typically don't have
> an /etc/mailname. How does trusting the file when present hurt?
I guess I am not explaining myself well. Trusting the file when present
does not hurt at all. But the logic above is making assumptions about
the state when the file is _not_ present (i.e., the "if you do not..."
clause above). On Debian, we might assume that if /etc/mailname is not
present that this is a clue that the machine cannot produce a useful
address. But on other operating systems, that is not a useful clue (it
is simply that /etc/mailname is not used on that system). Dying on such
a system when /etc/mailname is not present would be a regression.
Does that make more sense?
> I *am* a bit worried about what people might put in /etc/mailname on
> Debian systems when there is no appropriate host to put there (as on
> Thorsten's machine).
Yeah. Or even in a split-horizon setup where the mail is deliverable but
does not reflect the public identity of the user. I think we are getting
down to the question I mentioned elsewhere: it is not about whether we
have a deliverable address or not, but what users want to cement in
history for all time as their identity.
So thinking too much about /etc/mailname versus gethostname is probably
not useful. Either it is worth breaking the few (if any) users who
depend on the auto ident in favor of fewer accidental implicit idents
making their way into the wild, or it is not.
-Peff
next prev parent reply other threads:[~2013-08-10 7:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130809134236.28143.75775.reportbug@tglase.lan.tarent.de>
2013-08-09 19:42 ` git should not use a default user.email config value Jonathan Nieder
2013-08-09 20:00 ` Thorsten Glaser
2013-08-09 20:30 ` Felipe Contreras
2013-08-13 8:29 ` Matthieu Moy
2013-08-09 22:37 ` Jeff King
2013-08-09 23:06 ` Junio C Hamano
2013-08-10 6:17 ` Jeff King
2013-08-10 6:40 ` Jonathan Nieder
2013-08-10 6:52 ` Jeff King
2013-08-10 7:03 ` Jonathan Nieder
2013-08-10 7:14 ` Jeff King [this message]
2013-08-09 23:19 ` Jonathan Nieder
2013-08-10 6:47 ` Jeff King
2013-08-10 9:59 ` Michael Haggerty
2013-08-10 10:28 ` Jeff King
2013-08-10 11:42 ` Michael Haggerty
2013-08-10 12:06 ` Thorsten Glaser
2013-08-10 12:34 ` Andreas Schwab
2013-08-12 12:51 ` Greg Troxel
2013-08-10 16:58 ` Junio C Hamano
2013-08-12 11:52 ` Andrew Ardill
2013-08-12 12:39 ` Jeff King
2013-08-12 12:54 ` Michael Haggerty
2013-08-12 15:49 ` Jeff King
2013-08-12 13:01 ` Andrew Ardill
2013-08-12 15:45 ` Jeff King
2013-08-13 11:05 ` Andrew Ardill
2013-08-13 11:46 ` Jeff King
2013-08-13 12:05 ` Jeff King
2013-08-13 12:52 ` Andrew Ardill
2013-08-13 15:53 ` Jeff King
2013-08-13 16:33 ` Junio C Hamano
2013-08-14 7:28 ` Matthieu Moy
2013-08-14 7:40 ` Jeff King
2013-08-14 8:37 ` Matthieu Moy
2013-08-14 14:00 ` Junio C Hamano
2013-08-14 14:07 ` Matthieu Moy
2013-08-14 14:08 ` conditional config syntax Jeff King
2013-08-14 15:41 ` Junio C Hamano
2013-08-14 7:09 ` git should not use a default user.email config value Michael Haggerty
2013-08-14 7:31 ` Jeff King
2013-08-13 16:31 ` Junio C Hamano
2013-08-13 8:08 ` Matthieu Moy
2013-08-11 0:06 ` Aaron Schrab
2013-08-13 8:24 ` Matthieu Moy
2013-08-13 8:39 ` Thorsten Glaser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130810071407.GA32038@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=tg@mirbsd.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).