Re: [PATCH] git exproll: steps to tackle gc aggression

[Jeff King <peff@peff.net>]

On Sat, Aug 10, 2013 at 04:24:48PM +0700, Nguyen Thai Ngoc Duy wrote:

> > Yeah, I read about the --thin option. However, it's only for
> > network-packs (i.e --stdout; why?). Also, is it turned on by default?
> > The documentation says so, but I ran it and found that the value of
> > thin is 0 in builtin/push.c:316. What is going on?
> 
> --thin is enabled by default for fetch (see
> transport.c:transport_get()) but it's only effective when the server
> advertises "thin-pack" capability (see protocol-capabilities.txt).
> push has --thin turned off by default favoring server resources over
> network traffic, see a4503a1 (Make --no-thin the default in git-push
> to save server resources - 2007-09-09)

Hmm. I don't think that is the case anymore.

If I do:

  git init parent &&
  (cd parent && seq 1 10000 >file &&
   git add file && git commit -m base
  ) &&
  git clone parent child &&
  cd child && seq 1 10001 >file &&
  git commit -a -m more &&
  GIT_TRACE=1 git push origin HEAD:foo

I see:

  trace: run_command: 'pack-objects' '--all-progress-implied' '--revs'
    '--stdout' '--thin' '--delta-base-offset' '--progress'

-Peff