From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matan Nassau <matan.nassau@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Bug: commit -p breaks with -m
Date: Thu, 15 Aug 2013 13:31:58 -0400 [thread overview]
Message-ID: <20130815173158.GA27866@sigill.intra.peff.net> (raw)
In-Reply-To: <7v1u5usw27.fsf@alter.siamese.dyndns.org>
On Thu, Aug 15, 2013 at 10:28:16AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Unfortunately, I think that will require some refactoring of the
> > run_hook interface, which does not allow arbitrary environment
> > parameters to be set.
>
> Heh, I said that long time ago, e.g. $gmane/212284 ;-)
>
> This might turn out to be a good starting point, even though I
> didn't read it again before sending this message.
>
> http://thread.gmane.org/gmane.comp.version-control.git/192669/focus=192806
Looking at both of those messages, I agree completely. I even started
to sketch out the refactoring when I sent the previous message, and it
looked a lot like the patch you sent.
-Peff
prev parent reply other threads:[~2013-08-15 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 4:43 Bug: commit -p breaks with -m Matan Nassau
2013-08-15 12:16 ` Jeff King
2013-08-15 17:28 ` Junio C Hamano
2013-08-15 17:31 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815173158.GA27866@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matan.nassau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).