From: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [GUILT] add FreeBSD support
Date: Tue, 20 Aug 2013 11:25:48 -0400 [thread overview]
Message-ID: <20130820152547.GC8172@poseidon.cudanet.local> (raw)
In-Reply-To: <20130820074415.GA27247@gmail.com>
On Tue, Aug 20, 2013 at 03:44:16PM +0800, Zheng Liu wrote:
> Hi Josef,
>
> On Fri, Aug 09, 2013 at 11:20:46AM -0400, Josef 'Jeff' Sipek wrote:
> > On Fri, Aug 09, 2013 at 11:04:45PM +0800, gnehzuil.liu wrote:
> > > ?? 2013-8-9??????10:46??Josef 'Jeff' Sipek <jeffpc@josefsipek.net> д????
> > >
> > > > On Fri, Aug 09, 2013 at 08:32:28PM +0800, Zheng Liu wrote:
> > > >> From: Zheng Liu <gnehzuil.liu@gmail.com>
> > > >>
> > > >> Currently guilt doesn't support FreeBSD platform. This commit tries to
> > > >> add this support. The file called 'os.FreeBSD' is copied from os.Darwin
> > > >> due to these two platforms have almost the same command tools.
> > > >
> > > > Out of curiosity, is it identical? I eyeballed it, and they do look
> > > > identical. There's probably a better way to do this whole os-specific
> > > > thing, but this will work well enough for now.
> > >
> > > Yes, it is identical. Sorry, I am a newbie for guilt, but I am happy to
> > > improve this os-specific thing. Any idea?
> >
> > So, I'm a bit torn between some "build-time" checking that generates
> > something like an "os" file based on what it detects and something that
> > happens at runtime. I like that currently there's nothing to do - you just
> > clone the repo and you're set. At the same time, the more code can be
> > avoided executing the faster (in theory) guilt gets.
>
> Sorry for the late reply. I did a simple experiment that tries to fold
> all os.* files into one file and uses a if statement to export functions
> according to different platforms. But frankly I don't like this because
> it is not very clearly. So IMHO we'd better add a 'os.FreeBSD' file to
> support FreeBSD platform.
Yeah, sounds like the simplest (at least for the moment). I'll commit it.
Thanks.
FWIW, the idea I was thinking about was to make "make all" figure out
various parts of the system and construct an os file.
Jeff.
--
UNIX is user-friendly ... it's just selective about who its friends are
next prev parent reply other threads:[~2013-08-20 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 12:32 [GUILT] add FreeBSD support Zheng Liu
2013-08-09 14:46 ` Josef 'Jeff' Sipek
2013-08-09 15:04 ` gnehzuil.liu
2013-08-09 15:20 ` Josef 'Jeff' Sipek
2013-08-20 7:44 ` Zheng Liu
2013-08-20 15:25 ` Josef 'Jeff' Sipek [this message]
2013-08-21 2:04 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820152547.GC8172@poseidon.cudanet.local \
--to=jeffpc@josefsipek.net \
--cc=git@vger.kernel.org \
--cc=gnehzuil.liu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).