From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <stefanbeller@googlemail.com>,
Thomas Rast <trast@inf.ethz.ch>,
git@vger.kernel.org
Subject: Re: [PATCH] mailmap: fix check for freeing memory
Date: Tue, 20 Aug 2013 13:45:05 -0400 [thread overview]
Message-ID: <20130820174505.GA10106@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqob8s7033.fsf@gitster.dls.corp.google.com>
On Tue, Aug 20, 2013 at 10:18:08AM -0700, Junio C Hamano wrote:
> As you mentioned, merge gives readable merge log messages, but it
> deliberately uses the real URL, not your personal nickname for the
> remote when writing the title line of a merge, i.e.
>
> Merge [branch <x> of ]<repoURL>
>
> so it would be helped by the repository abbreviation. It probably
> was an oversight that we did not extend it to the rest of the log
> family.
Ah, yeah, I suppose git-pull will still do that. I was thinking of a
direct git-merge of a tracking branch, which would end up with:
Merge remote-tracking branch 'origin/master'
whereas "git pull origin master" in the same case would say:
Merge branch 'master' of git://github.com/gitster/git
Still, I do not think anybody but the kernel is using it. Most people
simply have shorter URLs that do not need abbreviated (e.g., the GitHub
one shown above). And searching for instances on GitHub yields only the
kernel:
https://github.com/search?q=repo-abbrev+path%3A.mailmap&type=Code
Anyway, I am not proposing ripping the feature out. It just seems like
it does not have a lot of users, and it is not worth worrying much about
trying to extend it.
-Peff
next prev parent reply other threads:[~2013-08-20 17:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 13:22 [PATCH] mailmap: fix check for freeing memory Stefan Beller
2013-08-20 13:40 ` Thomas Rast
2013-08-20 13:52 ` Jeff King
2013-08-20 14:17 ` Stefan Beller
2013-08-20 14:18 ` [PATCH] mailmap: remove redundant " Stefan Beller
2013-08-20 14:28 ` Jeff King
2013-08-20 14:23 ` [PATCH] mailmap: fix " Thomas Rast
2013-08-20 14:38 ` Stefan Beller
2013-08-20 16:12 ` Jeff King
2013-08-20 17:18 ` Junio C Hamano
2013-08-20 17:45 ` Jeff King [this message]
2013-08-20 14:27 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820174505.GA10106@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stefanbeller@googlemail.com \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).