From: Christian Couder <chriscool@tuxfamily.org>
To: j6t@kdbg.org
Cc: gitster@pobox.com, git@vger.kernel.org, philipoakley@iee.org,
trast@inf.ethz.ch
Subject: Re: [PATCH 1/5] replace: forbid replacing an object with one of a different type
Date: Sun, 25 Aug 2013 21:44:17 +0200 (CEST) [thread overview]
Message-ID: <20130825.214417.1308749312477487067.chriscool@tuxfamily.org> (raw)
In-Reply-To: <521A4E83.9000400@kdbg.org>
From: Johannes Sixt <j6t@kdbg.org>
> Am 25.08.2013 15:06, schrieb Christian Couder:
>> @@ -100,6 +101,15 @@ static int replace_object(const char *object_ref, const char *replace_ref,
>> if (check_refname_format(ref, 0))
>> die("'%s' is not a valid ref name.", ref);
>>
>> + obj_type = sha1_object_info(object, NULL);
>> + repl_type = sha1_object_info(repl, NULL);
>> + if (obj_type != repl_type)
>> + die("Objects must be of the same type.\n"
>> + "Object ref '%s' is of type '%s'\n"
>
> Is it really an "Object ref", not just an "Object"?
Well, it is what is passed to the command line. It is then converted into an
hex sha1 using get_sha1() and then sha1_to_hex().
What about:
die("Objects must be of the same type.\n"
"'%s' points to a replaced object of type '%s'\n"
"while '%s' points to a replacement object of type '%s'.",
> BTW, I appreciate your choice of where in the sentence the line breaks are.
Thanks,
Christian.
next prev parent reply other threads:[~2013-08-25 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-25 13:06 [PATCH 0/5] Check replacement object type and minor updates Christian Couder
2013-08-25 13:06 ` [PATCH 1/5] replace: forbid replacing an object with one of a different type Christian Couder
2013-08-25 18:35 ` Johannes Sixt
2013-08-25 19:44 ` Christian Couder [this message]
2013-08-25 20:18 ` Johannes Sixt
2013-08-26 7:19 ` Christian Couder
2013-08-25 13:06 ` [PATCH 2/5] Documentation/replace: state that objects must be of the same type Christian Couder
2013-08-25 13:06 ` [PATCH 3/5] t6050-replace: test that objects are " Christian Couder
2013-08-25 20:06 ` Johannes Sixt
2013-08-25 13:06 ` [PATCH 4/5] t6050-replace: add test to clean up all the replace refs Christian Couder
2013-08-25 13:06 ` [PATCH 5/5] Documentation/replace: add Creating Replacement Objects section Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130825.214417.1308749312477487067.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=philipoakley@iee.org \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).