From: Jeff King <peff@peff.net>
To: Antoine Pelisse <apelisse@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] commit: search author pattern against mailmap
Date: Sun, 25 Aug 2013 00:01:22 -0400 [thread overview]
Message-ID: <20130825040122.GA18676@sigill.intra.peff.net> (raw)
In-Reply-To: <1377353267-3886-1-git-send-email-apelisse@gmail.com>
On Sat, Aug 24, 2013 at 04:07:47PM +0200, Antoine Pelisse wrote:
> @@ -945,13 +947,16 @@ static const char *find_author_by_nickname(const char *name)
> av[++ac] = buf.buf;
> av[++ac] = NULL;
> setup_revisions(ac, av, &revs, NULL);
> + revs.mailmap = &mailmap;
> + read_mailmap(revs.mailmap, NULL);
> +
> prepare_revision_walk(&revs);
> commit = get_revision(&revs);
> if (commit) {
> struct pretty_print_context ctx = {0};
> ctx.date_mode = DATE_NORMAL;
> strbuf_release(&buf);
> - format_commit_message(commit, "%an <%ae>", &buf, &ctx);
> + format_commit_message(commit, "%aN <%aE>", &buf, &ctx);
> return strbuf_detach(&buf, NULL);
> }
> die(_("No existing author found with '%s'"), name);
Do we need to clear_mailmap before returning to avoid a leak?
I suspect we may be leaking pending commits from the revision walker,
too, but I'm not sure we have an easy "clear everything" function there.
-Peff
next prev parent reply other threads:[~2013-08-25 4:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 13:48 [PATCH] git-commit: search author pattern against mailmap Antoine Pelisse
2013-08-23 17:44 ` Junio C Hamano
2013-08-23 18:35 ` Jeff King
2013-08-23 19:03 ` Junio C Hamano
2013-08-23 19:47 ` Antoine Pelisse
2013-08-23 20:44 ` Junio C Hamano
2013-08-24 14:07 ` [PATCH] commit: " Antoine Pelisse
2013-08-25 4:01 ` Jeff King [this message]
2013-08-25 5:16 ` Junio C Hamano
2013-08-25 9:47 ` Antoine Pelisse
2013-08-25 10:01 ` Antoine Pelisse
2013-08-25 10:30 ` Jeff King
2013-08-25 13:37 ` Antoine Pelisse
2013-08-25 16:51 ` Jeff King
2013-08-25 20:42 ` Antoine Pelisse
2013-08-26 5:27 ` Junio C Hamano
2013-08-26 21:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130825040122.GA18676@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=apelisse@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).