git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Thomas Ackermann <th.acker@arcor.de>
Cc: git@vger.kernel.org, gitster@pobox.com, wking@tremily.us
Subject: Re: [PATCH 09/13] Improve section "Merge multiple trees"
Date: Sat, 24 Aug 2013 22:23:27 -0700	[thread overview]
Message-ID: <20130825052327.GK2882@elie.Belkin> (raw)
In-Reply-To: <1473018875.1091101.1377329545934.JavaMail.ngmail@webmail08.arcor-online.net>

Thomas Ackermann wrote:

> --- a/Documentation/user-manual.txt
> +++ b/Documentation/user-manual.txt
> @@ -3992,16 +3992,16 @@ Merging multiple trees
>  
>  Git helps you do a three-way merge, which you can expand to n-way by
>  repeating the merge procedure arbitrary times until you finally
> -"commit" the state.
> +commit the state.

The above sentence is unclear to me both before and after this change.

Git helps me do a three-way merge, but I'm on my own if I want to
expand to n-way?  Those times I repeat it are arbitrary times, not
arbitrarily many times?  Using "git merge" I make commits, but I
do not finally commit to the result until the (n-1)st?  And what is
this state I am committing?

Maybe the intent is

	Git can help you perform a three-way merge, which can in turn be
	used for a many-way merge by repeating the merge procedure several
	times.  The usual situation is that you only do one three-way merge
	(reconciling two lines of history) and commit the result, but if
	you like to, you can merge several branches in one go.

	To perform a three-way merge, you start with the two commits you
	want to merge, find their closest common parent (a third commit),
	and compare the trees corresponding to these three commits.

	To get the "base" for the merge, look up the common parent of two
	commits:

		$ git merge-base <commit1> <commit2>

	This prints the name of a commit they are both based on.
	...

[...]
> -To get the "base" for the merge, you first look up the common parent
> +To get the base for the merge, you first look up the common parent

Merge base hasn't been defined, so this is using quotes to point out
that it is defining a new, unfamiliar term.

[...]
> -now look up the "tree" objects of those commits, which you can easily
> -do with (for example)
> +now look up the tree objects of those commits, which you can easily
> +do with

Yes.

  reply	other threads:[~2013-08-25  5:23 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-24  7:22 [PATCH 0/13] Modernize user-manual Thomas Ackermann
2013-08-24  7:24 ` [PATCH 01/13] Call it "Git User Manual" and remove reference to very old Git version Thomas Ackermann
2013-08-25  3:05   ` Jonathan Nieder
2013-08-25  3:07   ` Junio C Hamano
2013-08-24  7:25 ` [PATCH 02/13] Use current "detached HEAD" message Thomas Ackermann
2013-08-25  3:49   ` Jonathan Nieder
2013-08-25  8:10   ` Aw: " Thomas Ackermann
2013-08-24  7:26 ` [PATCH 03/13] Use current output for "git repack" Thomas Ackermann
2013-08-25  4:15   ` Jonathan Nieder
2013-08-25  8:37   ` Aw: " Thomas Ackermann
2013-08-24  7:27 ` [PATCH 04/13] Use "git merge" instead of "git pull ." Thomas Ackermann
2013-08-25  3:17   ` Junio C Hamano
2013-08-25  4:19   ` Jonathan Nieder
2013-08-25  5:26     ` Martin von Zweigbergk
2013-08-24  7:28 ` [PATCH 05/13] Fix some typos Thomas Ackermann
2013-08-25  5:01   ` Jonathan Nieder
2013-08-25  9:13   ` Aw: " Thomas Ackermann
2013-08-24  7:29 ` [PATCH 06/13] Simplify "How to make a commit" Thomas Ackermann
2013-08-25  3:20   ` Junio C Hamano
2013-08-25  5:05   ` Jonathan Nieder
2013-08-25  9:20   ` Aw: " Thomas Ackermann
2013-08-24  7:30 ` [PATCH 07/13] Improve description in "How to merge" Thomas Ackermann
2013-08-25  3:22   ` Junio C Hamano
2013-08-25  5:08   ` Jonathan Nieder
2013-08-25 11:31   ` Aw: " Thomas Ackermann
2013-08-24  7:31 ` [PATCH 08/13] Improve section "Manipulating branches" Thomas Ackermann
2013-08-25  3:25   ` Junio C Hamano
2013-08-25 11:41   ` Aw: " Thomas Ackermann
2013-08-24  7:32 ` [PATCH 09/13] Improve section "Merge multiple trees" Thomas Ackermann
2013-08-25  5:23   ` Jonathan Nieder [this message]
2013-08-25 12:06   ` Aw: " Thomas Ackermann
2013-08-25 20:10     ` Jonathan Nieder
2013-08-24  7:33 ` [PATCH 10/13] Remove unnecessary historical note from "Object storage format" Thomas Ackermann
2013-08-25  3:28   ` Junio C Hamano
2013-08-24  7:34 ` [PATCH 11/13] Remove obscure reference from "Examples" Thomas Ackermann
2013-08-25  3:53   ` Junio C Hamano
2013-08-25  5:25   ` Jonathan Nieder
2013-08-25  9:30   ` Aw: " Thomas Ackermann
2013-08-24  7:35 ` [PATCH 12/13] Remove irrelevant reference from "Tying it all together" Thomas Ackermann
2013-08-25  3:56   ` Junio C Hamano
2013-08-26 13:51     ` Jon Loeliger
2013-08-24  7:37 ` [PATCH 13/13] "git prune" is safe now Thomas Ackermann
2013-08-25  3:59   ` Junio C Hamano
2013-08-24 19:31 ` [PATCH 0/13] Modernize user-manual Philip Oakley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130825052327.GK2882@elie.Belkin \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=th.acker@arcor.de \
    --cc=wking@tremily.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).