From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Phil Hord <hordp@cisco.com>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, phil.hord@gmail.com
Subject: Re: [RFC/PATCH] Fix path prefixing in grep_object
Date: Sun, 25 Aug 2013 01:54:33 -0400 [thread overview]
Message-ID: <20130825055433.GA7296@sigill.intra.peff.net> (raw)
In-Reply-To: <20130825054142.GM2882@elie.Belkin>
On Sat, Aug 24, 2013 at 10:41:42PM -0700, Jonathan Nieder wrote:
> Jeff King wrote:
>
> > So we are necessarily reconstructing based on what we know of the
> > syntax. And I think that your rule is OK, because we know that refnames
> > cannot contain a colon.
>
> What happens with expressions like HEAD^{/test:}?
Ugh, right. Names are more than just refnames.
So I think the only way to do this robustly is to ask get_sha1 to
remember more about what happened. We might even be able to get away
without teaching get_sha1_with_context anything else; it already records
the path, so we should be able to just check whether that is non-empty.
But we use an object_array to store the list of objects, and it has no
room for such a bit. So we'd probably want to refactor that, too.
-Peff
prev parent reply other threads:[~2013-08-25 5:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-25 1:35 [RFC/PATCH] Fix path prefixing in grep_object Phil Hord
2013-08-25 2:07 ` Phil Hord
2013-08-25 3:35 ` Junio C Hamano
2013-08-25 4:23 ` Jonathan Nieder
2013-08-25 5:25 ` Junio C Hamano
2013-08-26 7:14 ` Junio C Hamano
2013-08-26 11:44 ` Phil Hord
2013-08-26 16:23 ` Junio C Hamano
2013-08-26 16:49 ` Phil Hord
2013-08-26 17:07 ` Phil Hord
2013-08-26 17:26 ` Junio C Hamano
2013-08-26 17:45 ` Phil Hord
2013-08-27 4:07 ` Junio C Hamano
2013-08-27 11:54 ` Phil Hord
2013-08-26 17:03 ` Junio C Hamano
2013-08-26 17:19 ` Phil Hord
2013-08-25 4:41 ` Jeff King
2013-08-25 5:41 ` Jonathan Nieder
2013-08-25 5:54 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130825055433.GA7296@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hordp@cisco.com \
--cc=jrnieder@gmail.com \
--cc=phil.hord@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).