git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Documentation/fast-import: clarify summary for `feature` command
@ 2013-08-23  8:29 Matthieu Moy
  2013-08-25  5:57 ` Jonathan Nieder
  0 siblings, 1 reply; 2+ messages in thread
From: Matthieu Moy @ 2013-08-23  8:29 UTC (permalink / raw)
  To: git, gitster; +Cc: Matthieu Moy

In most cases, "feature <foo>" does not just require that the feature
exists, but also changes the behavior to enable it.

Cases where the feature is only requested like cat-blob, notes or ls are
clearly documented below.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 Documentation/git-fast-import.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
index bf1a02a..4a9cc74 100644
--- a/Documentation/git-fast-import.txt
+++ b/Documentation/git-fast-import.txt
@@ -361,8 +361,8 @@ and control the current import process.  More detailed discussion
 	`--cat-blob-fd` or `stdout` if unspecified.
 
 `feature`::
-	Require that fast-import supports the specified feature, or
-	abort if it does not.
+	Enable the specified feature. This requires that fast-import
+	supports the specified feature, and aborts if it does not.
 
 `option`::
 	Specify any of the options listed under OPTIONS that do not
-- 
1.8.4.rc4.4.g57d5d3d

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Documentation/fast-import: clarify summary for `feature` command
  2013-08-23  8:29 [PATCH] Documentation/fast-import: clarify summary for `feature` command Matthieu Moy
@ 2013-08-25  5:57 ` Jonathan Nieder
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Nieder @ 2013-08-25  5:57 UTC (permalink / raw)
  To: Matthieu Moy; +Cc: git, gitster

Matthieu Moy wrote:

> In most cases, "feature <foo>" does not just require that the feature
> exists, but also changes the behavior to enable it.

For what it's worth,

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-25  5:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-23  8:29 [PATCH] Documentation/fast-import: clarify summary for `feature` command Matthieu Moy
2013-08-25  5:57 ` Jonathan Nieder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).